You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Brian Towles via Review Board <no...@reviews.apache.org> on 2018/08/07 21:00:06 UTC
Review Request 68264: SENTRY-2335: Allow sentry to have multiple
handlers for a Signal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68264/
-----------------------------------------------------------
Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
Bugs: SENTRY-2335
https://issues.apache.org/jira/browse/SENTRY-2335
Repository: sentry
Description
-------
This changes the SigUtil class to allow for multiple signal handler functions to be defined and executed per signal.
Diffs
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java 1f16e1435dde850d651b9b9f5ad8e6253269d106
Diff: https://reviews.apache.org/r/68264/diff/1/
Testing
-------
Tested with unit tests and manual testing
Thanks,
Brian Towles
Re: Review Request 68264: SENTRY-2335: Allow sentry to have multiple
handlers for a Signal
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
> On Aug. 8, 2018, 2:48 p.m., Na Li wrote:
> > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java
> > Line 66 (original), 72 (patched)
> > <https://reviews.apache.org/r/68264/diff/1/?file=2070013#file2070013line74>
> >
> > should we use try/catch here? So if one handler fails to handle the signal, the next handlers can still process the singnal?
Yeah this makes sense.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68264/#review206992
-----------------------------------------------------------
On Aug. 7, 2018, 4 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68264/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 4 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2335
> https://issues.apache.org/jira/browse/SENTRY-2335
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This changes the SigUtil class to allow for multiple signal handler functions to be defined and executed per signal.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java 1f16e1435dde850d651b9b9f5ad8e6253269d106
>
>
> Diff: https://reviews.apache.org/r/68264/diff/1/
>
>
> Testing
> -------
>
> Tested with unit tests and manual testing
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68264: SENTRY-2335: Allow sentry to have multiple
handlers for a Signal
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68264/#review206992
-----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java
Line 66 (original), 72 (patched)
<https://reviews.apache.org/r/68264/#comment290154>
should we use try/catch here? So if one handler fails to handle the signal, the next handlers can still process the singnal?
- Na Li
On Aug. 7, 2018, 9 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68264/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 9 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2335
> https://issues.apache.org/jira/browse/SENTRY-2335
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This changes the SigUtil class to allow for multiple signal handler functions to be defined and executed per signal.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java 1f16e1435dde850d651b9b9f5ad8e6253269d106
>
>
> Diff: https://reviews.apache.org/r/68264/diff/1/
>
>
> Testing
> -------
>
> Tested with unit tests and manual testing
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68264: SENTRY-2335: Allow sentry to have multiple
handlers for a Signal
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68264/#review206998
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Aug. 8, 2018, 8:25 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68264/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2018, 8:25 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2335
> https://issues.apache.org/jira/browse/SENTRY-2335
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This changes the SigUtil class to allow for multiple signal handler functions to be defined and executed per signal.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java 1f16e1435dde850d651b9b9f5ad8e6253269d106
>
>
> Diff: https://reviews.apache.org/r/68264/diff/2/
>
>
> Testing
> -------
>
> Tested with unit tests and manual testing
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68264: SENTRY-2335: Allow sentry to have multiple
handlers for a Signal
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68264/
-----------------------------------------------------------
(Updated Aug. 8, 2018, 3:25 p.m.)
Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
Changes
-------
Added try/catch for signal handler running
Bugs: SENTRY-2335
https://issues.apache.org/jira/browse/SENTRY-2335
Repository: sentry
Description
-------
This changes the SigUtil class to allow for multiple signal handler functions to be defined and executed per signal.
Diffs (updated)
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java 1f16e1435dde850d651b9b9f5ad8e6253269d106
Diff: https://reviews.apache.org/r/68264/diff/2/
Changes: https://reviews.apache.org/r/68264/diff/1-2/
Testing
-------
Tested with unit tests and manual testing
Thanks,
Brian Towles