You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/31 15:35:15 UTC

[GitHub] [camel-k] essobedo opened a new pull request, #3595: fix: Prevent panic on wrong Kamelet binding

essobedo opened a new pull request, #3595:
URL: https://github.com/apache/camel-k/pull/3595

   ## Motivation
   
   A Kamelet binding in the wrong format can lead to operator panic which needs to be avoided.
   
   ## Modifications:
   
   * Adds a function to verify the Kamelet binding to return an error in case of an invalid format. 
   
   **Release Note**
   ```release-note
   fix: Prevent panic on wrong Kamelet binding
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] essobedo closed pull request #3595: fix: Prevent operator panic on wrong Kamelet binding

Posted by GitBox <gi...@apache.org>.
essobedo closed pull request #3595: fix: Prevent operator panic on wrong Kamelet binding
URL: https://github.com/apache/camel-k/pull/3595


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] essobedo commented on pull request #3595: fix: Prevent operator panic on wrong Kamelet binding

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #3595:
URL: https://github.com/apache/camel-k/pull/3595#issuecomment-1233855059

   The builds are failing due to:
   
   * TestNativeIntegrations/automatic_rollout_deployment_from_fast-jar_to_native_kit
   * TestKitKnativeFullBuild
   
   Both are not related to these changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on a diff in pull request #3595: fix: Prevent operator panic on wrong Kamelet binding

Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3595:
URL: https://github.com/apache/camel-k/pull/3595#discussion_r961290354


##########
pkg/controller/kameletbinding/error_handler.go:
##########
@@ -46,11 +46,7 @@ func maybeErrorHandler(errHandlConf *v1alpha1.ErrorHandlerSpec, bindingContext b
 			}
 		}
 
-		err = setErrorHandlerConfiguration(errorHandlerBinding, errorHandlerSpec)
-		if err != nil {
-			return nil, errors.Wrap(err, "could not set integration error handler")
-		}
-
+		setErrorHandlerConfiguration(errorHandlerBinding, errorHandlerSpec)

Review Comment:
   Should we really remove this error handling here?  I see in this func it's not needed as it's already validated above, but what if some one else found `setErrorHandlerConfiguration()` useful and wanted to invoke it somewhere else?
   I feel it's safe to keep this as is along with the `setErrorHandlerConfiguration()` func.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] essobedo commented on pull request #3595: fix: Prevent operator panic on wrong Kamelet binding

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #3595:
URL: https://github.com/apache/camel-k/pull/3595#issuecomment-1239087141

   Ok no problem once https://github.com/apache/camel-k-runtime/pull/868 will be fixed, I will try to find a more elegant approach


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org