You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2024/07/29 10:39:28 UTC
[PR] Docs: Clarify wording on releases [iceberg]
Fokko opened a new pull request, #10806:
URL: https://github.com/apache/iceberg/pull/10806
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Clarify wording on releases [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #10806:
URL: https://github.com/apache/iceberg/pull/10806#discussion_r1699542915
##########
site/docs/how-to-release.md:
##########
@@ -76,17 +70,33 @@ For more information, see the Gradle [signing documentation](https://docs.gradle
The release should be executed against `https://github.com/apache/iceberg.git` instead of any fork.
Set it as remote with name `apache` for release if it is not already set up.
-## Creating a release candidate
+## Initiating a new release
### Initiate a discussion about the release with the community
-This step can be useful to gather ongoing patches that the community thinks should be in the upcoming release.
+A new release can be started by raising a thread on the [dev-list](https://lists.apache.org/list.html?dev@iceberg.apache.org):
+
+```txt
+------------------------------------------------------------
+To: dev@iceberg.apache.org
+Subject: [DISCUSS] Apache Iceberg Release x.y.z?
+
+Hello everyone,
+
+I would like to discuss a new release of Iceberg because of:
+```
+
+For what goes into which release, please refer to [semantic versioning](contribute.md#semantic-versioning) section on the contributing page.
+
+Decisions about releases are made by three groups:
-The communication can be started via a [DISCUSS] mail on the dev@ channel and the desired tickets can be added to the github milestone of the next release.
+* **Release Manager**: Does the work of creating the release, signing it, counting [votes](#voting), announcing the release and so on. Requires the assistance of a committer for some steps.
+* **The community**: Performs the discussion of whether it is the right time to create a release and what that release should contain. Everyone is encouraged to test, validate, and vote on the release to help prevent regressions or issues.
Review Comment:
@emkornfield That's correct, but not part of this PR. https://github.com/apache/iceberg/pull/9666 suggests to have a PR every three months.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Clarify wording on releases [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #10806:
URL: https://github.com/apache/iceberg/pull/10806#discussion_r1698023210
##########
site/docs/how-to-release.md:
##########
@@ -76,17 +70,33 @@ For more information, see the Gradle [signing documentation](https://docs.gradle
The release should be executed against `https://github.com/apache/iceberg.git` instead of any fork.
Set it as remote with name `apache` for release if it is not already set up.
-## Creating a release candidate
+## Initiating a new release
### Initiate a discussion about the release with the community
-This step can be useful to gather ongoing patches that the community thinks should be in the upcoming release.
+A new release can be started by raising a thread on the [dev-list](https://lists.apache.org/list.html?dev@iceberg.apache.org):
+
+```txt
+------------------------------------------------------------
+To: dev@iceberg.apache.org
+Subject: [DISCUSS] Apache Iceberg Release x.y.z?
+
+Hello everyone,
+
+I would like to discuss a new release of Iceberg because of:
+```
+
+For what goes into which release, please refer to [semantic versioning](contribute.md#semantic-versioning) section on the contributing page.
+
+Decisions about releases are made by three groups:
-The communication can be started via a [DISCUSS] mail on the dev@ channel and the desired tickets can be added to the github milestone of the next release.
+* **Release Manager**: Does the work of creating the release, signing it, counting [votes](#voting), announcing the release and so on. Requires the assistance of a committer for some steps.
+* **The community**: Performs the discussion of whether it is the right time to create a release and what that release should contain. The community is encouraged to cast non-binding votes on the release.
Review Comment:
```suggestion
* **The community**: Performs the discussion of whether it is the right time to create a release and what that release should contain. Everyone is encouraged to test, validate, and vote on the release to help prevent regressions or issues.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Clarify wording on releases [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #10806: Docs: Clarify wording on releases
URL: https://github.com/apache/iceberg/pull/10806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Clarify wording on releases [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #10806:
URL: https://github.com/apache/iceberg/pull/10806#discussion_r1695832403
##########
site/docs/how-to-release.md:
##########
@@ -76,17 +70,33 @@ For more information, see the Gradle [signing documentation](https://docs.gradle
The release should be executed against `https://github.com/apache/iceberg.git` instead of any fork.
Set it as remote with name `apache` for release if it is not already set up.
-## Creating a release candidate
+## Initiating a new release
### Initiate a discussion about the release with the community
-This step can be useful to gather ongoing patches that the community thinks should be in the upcoming release.
+A new release can be started by raising a thread on the [dev-list](https://lists.apache.org/list.html?dev@iceberg.apache.org):
+
+```txt
+------------------------------------------------------------
+To: dev@iceberg.apache.org
+Subject: [DISCUSS] Apache Iceberg Release x.y.z?
+
+Hello everyone,
+
+I would like to discuss a new release of Iceberg because of:
+```
+
+For what goes into which release, please refer to [semantic versioning](contribute.md#semantic-versioning) section on the contributing page.
+
+Decisions about releases are made by three groups:
-The communication can be started via a [DISCUSS] mail on the dev@ channel and the desired tickets can be added to the github milestone of the next release.
+* **Release Manager**: Does the work of creating the release, signing it, counting [votes](#voting), announcing the release and so on. Requires the assistance of a committer for some steps.
+* **The community**: Performs the discussion of whether it is the right time to create a release and what that release should contain. The community is encouraged to cast non-binding votes on the release.
Review Comment:
I typically phrase the last part as "everyone is encouraged to test, validate, and vote on the release to help prevent regressions or issues." While only PMC votes are binding, it is incredibly helpful when non-PMC members find and raise issues. I think the only reason that PMC votes are the only "binding" is because PMC members are the ones with the context for judgement calls (like whether a transient test failure should block a release) and the responsibility to check for more than just functionality (like licensing issues). It may be useful to clarify _why_ votes are structured this way, but I would at least recommend giving reasons for everyone to vote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Clarify wording on releases [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #10806:
URL: https://github.com/apache/iceberg/pull/10806#discussion_r1698023210
##########
site/docs/how-to-release.md:
##########
@@ -76,17 +70,33 @@ For more information, see the Gradle [signing documentation](https://docs.gradle
The release should be executed against `https://github.com/apache/iceberg.git` instead of any fork.
Set it as remote with name `apache` for release if it is not already set up.
-## Creating a release candidate
+## Initiating a new release
### Initiate a discussion about the release with the community
-This step can be useful to gather ongoing patches that the community thinks should be in the upcoming release.
+A new release can be started by raising a thread on the [dev-list](https://lists.apache.org/list.html?dev@iceberg.apache.org):
+
+```txt
+------------------------------------------------------------
+To: dev@iceberg.apache.org
+Subject: [DISCUSS] Apache Iceberg Release x.y.z?
+
+Hello everyone,
+
+I would like to discuss a new release of Iceberg because of:
+```
+
+For what goes into which release, please refer to [semantic versioning](contribute.md#semantic-versioning) section on the contributing page.
+
+Decisions about releases are made by three groups:
-The communication can be started via a [DISCUSS] mail on the dev@ channel and the desired tickets can be added to the github milestone of the next release.
+* **Release Manager**: Does the work of creating the release, signing it, counting [votes](#voting), announcing the release and so on. Requires the assistance of a committer for some steps.
+* **The community**: Performs the discussion of whether it is the right time to create a release and what that release should contain. The community is encouraged to cast non-binding votes on the release.
Review Comment:
@rdblue I fully agree.
The wording we have today is even less inviting:
I've updated the wording, let me know what you think đź‘Ť
```suggestion
* **The community**: Performs the discussion of whether it is the right time to create a release and what that release should contain. Everyone is encouraged to test, validate, and vote on the release to help prevent regressions or issues.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Clarify wording on releases [iceberg]
Posted by "emkornfield (via GitHub)" <gi...@apache.org>.
emkornfield commented on code in PR #10806:
URL: https://github.com/apache/iceberg/pull/10806#discussion_r1699442754
##########
site/docs/how-to-release.md:
##########
@@ -76,17 +70,33 @@ For more information, see the Gradle [signing documentation](https://docs.gradle
The release should be executed against `https://github.com/apache/iceberg.git` instead of any fork.
Set it as remote with name `apache` for release if it is not already set up.
-## Creating a release candidate
+## Initiating a new release
### Initiate a discussion about the release with the community
-This step can be useful to gather ongoing patches that the community thinks should be in the upcoming release.
+A new release can be started by raising a thread on the [dev-list](https://lists.apache.org/list.html?dev@iceberg.apache.org):
+
+```txt
+------------------------------------------------------------
+To: dev@iceberg.apache.org
+Subject: [DISCUSS] Apache Iceberg Release x.y.z?
+
+Hello everyone,
+
+I would like to discuss a new release of Iceberg because of:
+```
+
+For what goes into which release, please refer to [semantic versioning](contribute.md#semantic-versioning) section on the contributing page.
+
+Decisions about releases are made by three groups:
-The communication can be started via a [DISCUSS] mail on the dev@ channel and the desired tickets can be added to the github milestone of the next release.
+* **Release Manager**: Does the work of creating the release, signing it, counting [votes](#voting), announcing the release and so on. Requires the assistance of a committer for some steps.
+* **The community**: Performs the discussion of whether it is the right time to create a release and what that release should contain. Everyone is encouraged to test, validate, and vote on the release to help prevent regressions or issues.
Review Comment:
@Fokko I thought you mentioned java releases were following a cadence or did I misunderstand this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Clarify wording on releases [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #10806:
URL: https://github.com/apache/iceberg/pull/10806#discussion_r1695832403
##########
site/docs/how-to-release.md:
##########
@@ -76,17 +70,33 @@ For more information, see the Gradle [signing documentation](https://docs.gradle
The release should be executed against `https://github.com/apache/iceberg.git` instead of any fork.
Set it as remote with name `apache` for release if it is not already set up.
-## Creating a release candidate
+## Initiating a new release
### Initiate a discussion about the release with the community
-This step can be useful to gather ongoing patches that the community thinks should be in the upcoming release.
+A new release can be started by raising a thread on the [dev-list](https://lists.apache.org/list.html?dev@iceberg.apache.org):
+
+```txt
+------------------------------------------------------------
+To: dev@iceberg.apache.org
+Subject: [DISCUSS] Apache Iceberg Release x.y.z?
+
+Hello everyone,
+
+I would like to discuss a new release of Iceberg because of:
+```
+
+For what goes into which release, please refer to [semantic versioning](contribute.md#semantic-versioning) section on the contributing page.
+
+Decisions about releases are made by three groups:
-The communication can be started via a [DISCUSS] mail on the dev@ channel and the desired tickets can be added to the github milestone of the next release.
+* **Release Manager**: Does the work of creating the release, signing it, counting [votes](#voting), announcing the release and so on. Requires the assistance of a committer for some steps.
+* **The community**: Performs the discussion of whether it is the right time to create a release and what that release should contain. The community is encouraged to cast non-binding votes on the release.
Review Comment:
I typically phrase the last part as "everyone is encouraged to test, validate, and vote on the release to help prevent regressions or issues." While only PMC votes are binding, it is incredibly helpful when non-PMC members find and raise issues.
I think the only reason that PMC votes are the only "binding" is because PMC members are the ones with the context for judgement calls (like whether a transient test failure should block a release) and the responsibility to check for more than just functionality (like licensing issues). It may be useful to clarify _why_ votes are structured this way, but I would at least recommend giving reasons for everyone to vote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Clarify wording on releases [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10806:
URL: https://github.com/apache/iceberg/pull/10806#issuecomment-2480862641
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Clarify wording on releases [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10806:
URL: https://github.com/apache/iceberg/pull/10806#issuecomment-2466519755
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org