You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2016/06/15 22:44:52 UTC
[jclouds/jclouds] JCLOUDS-1028: Configure idempotent methods (#967)
Enable POST for Atmos, S3, and Swift.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/967
-- Commit Summary --
* JCLOUDS-1028: Configure idempotent methods
-- File Changes --
M apis/atmos/src/main/java/org/jclouds/atmos/AtmosApiMetadata.java (2)
M apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/SwiftApiMetadata.java (2)
M apis/s3/src/main/java/org/jclouds/s3/S3ApiMetadata.java (2)
M core/src/main/java/org/jclouds/Constants.java (3)
M core/src/main/java/org/jclouds/apis/internal/BaseApiMetadata.java (3)
M core/src/main/java/org/jclouds/http/internal/BaseHttpCommandExecutorService.java (10)
M core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java (6)
M core/src/test/java/org/jclouds/http/internal/BaseHttpCommandExecutorServiceTest.java (7)
M core/src/test/java/org/jclouds/http/internal/TrackingJavaUrlHttpCommandExecutorService.java (7)
M core/src/test/java/org/jclouds/rest/internal/BaseRestApiExpectTest.java (6)
M drivers/apachehc/src/main/java/org/jclouds/http/apachehc/ApacheHCHttpCommandExecutorService.java (7)
M drivers/gae/src/main/java/org/jclouds/gae/GaeHttpCommandExecutorService.java (7)
M drivers/okhttp/src/main/java/org/jclouds/http/okhttp/OkHttpCommandExecutorService.java (8)
M providers/dynect/src/main/java/org/jclouds/dynect/v3/config/DynECTHttpApiModule.java (6)
M providers/profitbricks/src/main/java/org/jclouds/profitbricks/http/ResponseStatusFromPayloadHttpCommandExecutorService.java (6)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/967.patch
https://github.com/jclouds/jclouds/pull/967.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/967
Re: [jclouds/jclouds] JCLOUDS-1028: Configure idempotent methods
(#967)
Posted by Andrew Gaul <no...@github.com>.
> @@ -57,6 +58,7 @@ public static Properties defaultProperties() {
> Properties properties = BaseHttpApiMetadata.defaultProperties();
> properties.setProperty(PROPERTY_REGIONS, "DEFAULT");
> properties.setProperty(PROPERTY_USER_METADATA_PREFIX, "X-Object-Meta-");
> + properties.setProperty(Constants.PROPERTY_IDEMPOTENT_METHODS, "DELETE,GET,HEAD,OPTIONS,POST,PUT");
Done.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/967/files/614babda21753ce367c76e40e34410aba64d9474#r67265106
Re: [jclouds/jclouds] JCLOUDS-1028: Configure idempotent methods
(#967)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -57,6 +58,7 @@ public static Properties defaultProperties() {
> Properties properties = BaseHttpApiMetadata.defaultProperties();
> properties.setProperty(PROPERTY_REGIONS, "DEFAULT");
> properties.setProperty(PROPERTY_USER_METADATA_PREFIX, "X-Object-Meta-");
> + properties.setProperty(Constants.PROPERTY_IDEMPOTENT_METHODS, "DELETE,GET,HEAD,OPTIONS,POST,PUT");
[nit] Use a static import like in the other properties (consider this also int he other classes)
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/967/files/614babda21753ce367c76e40e34410aba64d9474#r67264399
Re: [jclouds/jclouds] JCLOUDS-1028: Configure idempotent methods
(#967)
Posted by Andrew Gaul <no...@github.com>.
Addressed all outstanding review comments.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/967#issuecomment-226350516
Re: [jclouds/jclouds] JCLOUDS-1028: Configure idempotent methods
(#967)
Posted by Andrew Gaul <no...@github.com>.
> @@ -350,6 +350,9 @@
> */
> public static final String PROPERTY_MAX_PARALLEL_DELETES = "jclouds.max-parallel-deletes";
>
> + /** Comma-separated list of methods considered idempotent for purposes of retries. */
Done.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/967/files/614babda21753ce367c76e40e34410aba64d9474#r67265117
Re: [jclouds/jclouds] JCLOUDS-1028: Configure idempotent methods
(#967)
Posted by Ignasi Barrera <no...@github.com>.
Just a couple very minor comments. Looks good to me. Thanks @andrewgaul !
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/967#issuecomment-226349300
Re: [jclouds/jclouds] JCLOUDS-1028: Configure idempotent methods
(#967)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -350,6 +350,9 @@
> */
> public static final String PROPERTY_MAX_PARALLEL_DELETES = "jclouds.max-parallel-deletes";
>
> + /** Comma-separated list of methods considered idempotent for purposes of retries. */
Document the default values in the javadoc?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/967/files/614babda21753ce367c76e40e34410aba64d9474#r67264250
Re: [jclouds/jclouds] JCLOUDS-1028: Configure idempotent methods
(#967)
Posted by Andrew Gaul <no...@github.com>.
@nacx Please review.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/967#issuecomment-226342141