You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2016/08/04 00:19:53 UTC
Review Request 50776: ATLAS-1089: Storm hook should handle cyclic
references in topology object
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50776/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1089
https://issues.apache.org/jira/browse/ATLAS-1089
Repository: atlas
Description
-------
Updated Storm hook to handle cyclic references in Storm topology object
Diffs
-----
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java c4b4976
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java ce6a175
Diff: https://reviews.apache.org/r/50776/diff/
Testing
-------
Validated that Atlas Storm hook gracefully handles cyclic references in Storm topology object, using a test topology implementation.
Thanks,
Madhan Neethiraj
Re: Review Request 50776: ATLAS-1089: Storm hook should handle cyclic
references in topology object
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50776/#review144717
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On Aug. 4, 2016, 4:29 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50776/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 4:29 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1089
> https://issues.apache.org/jira/browse/ATLAS-1089
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated Storm hook to handle cyclic references in Storm topology object
>
>
> Diffs
> -----
>
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java c4b4976
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java ce6a175
>
> Diff: https://reviews.apache.org/r/50776/diff/
>
>
> Testing
> -------
>
> Validated that Atlas Storm hook gracefully handles cyclic references in Storm topology object, using a test topology implementation.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 50776: ATLAS-1089: Storm hook should handle cyclic
references in topology object
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50776/
-----------------------------------------------------------
(Updated Aug. 4, 2016, 4:29 a.m.)
Review request for atlas.
Changes
-------
Addressed review comment.
Bugs: ATLAS-1089
https://issues.apache.org/jira/browse/ATLAS-1089
Repository: atlas
Description
-------
Updated Storm hook to handle cyclic references in Storm topology object
Diffs (updated)
-----
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java c4b4976
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java ce6a175
Diff: https://reviews.apache.org/r/50776/diff/
Testing
-------
Validated that Atlas Storm hook gracefully handles cyclic references in Storm topology object, using a test topology implementation.
Thanks,
Madhan Neethiraj
Re: Review Request 50776: ATLAS-1089: Storm hook should handle cyclic
references in topology object
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Aug. 4, 2016, 3:12 a.m., Arun Mahadevan wrote:
> > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java, line 140
> > <https://reviews.apache.org/r/50776/diff/2/?file=1462267#file1462267line140>
> >
> > Minor: this line can be removed.
Good suggestion. Thanks Arun.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50776/#review144705
-----------------------------------------------------------
On Aug. 4, 2016, 4:29 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50776/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 4:29 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1089
> https://issues.apache.org/jira/browse/ATLAS-1089
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated Storm hook to handle cyclic references in Storm topology object
>
>
> Diffs
> -----
>
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java c4b4976
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java ce6a175
>
> Diff: https://reviews.apache.org/r/50776/diff/
>
>
> Testing
> -------
>
> Validated that Atlas Storm hook gracefully handles cyclic references in Storm topology object, using a test topology implementation.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 50776: ATLAS-1089: Storm hook should handle cyclic
references in topology object
Posted by Arun Mahadevan <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50776/#review144705
-----------------------------------------------------------
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java (line 140)
<https://reviews.apache.org/r/50776/#comment210748>
Minor: this line can be removed.
- Arun Mahadevan
On Aug. 4, 2016, 12:45 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50776/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 12:45 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1089
> https://issues.apache.org/jira/browse/ATLAS-1089
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated Storm hook to handle cyclic references in Storm topology object
>
>
> Diffs
> -----
>
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java c4b4976
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java ce6a175
>
> Diff: https://reviews.apache.org/r/50776/diff/
>
>
> Testing
> -------
>
> Validated that Atlas Storm hook gracefully handles cyclic references in Storm topology object, using a test topology implementation.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 50776: ATLAS-1089: Storm hook should handle cyclic
references in topology object
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50776/
-----------------------------------------------------------
(Updated Aug. 4, 2016, 12:45 a.m.)
Review request for atlas.
Changes
-------
Addressed the review comment.
Bugs: ATLAS-1089
https://issues.apache.org/jira/browse/ATLAS-1089
Repository: atlas
Description
-------
Updated Storm hook to handle cyclic references in Storm topology object
Diffs (updated)
-----
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java c4b4976
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java ce6a175
Diff: https://reviews.apache.org/r/50776/diff/
Testing
-------
Validated that Atlas Storm hook gracefully handles cyclic references in Storm topology object, using a test topology implementation.
Thanks,
Madhan Neethiraj
Re: Review Request 50776: ATLAS-1089: Storm hook should handle cyclic
references in topology object
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50776/#review144701
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On Aug. 4, 2016, 12:19 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50776/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 12:19 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1089
> https://issues.apache.org/jira/browse/ATLAS-1089
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated Storm hook to handle cyclic references in Storm topology object
>
>
> Diffs
> -----
>
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java c4b4976
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java ce6a175
>
> Diff: https://reviews.apache.org/r/50776/diff/
>
>
> Testing
> -------
>
> Validated that Atlas Storm hook gracefully handles cyclic references in Storm topology object, using a test topology implementation.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 50776: ATLAS-1089: Storm hook should handle cyclic
references in topology object
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50776/#review144700
-----------------------------------------------------------
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java (line 134)
<https://reviews.apache.org/r/50776/#comment210746>
should we use a HashSet instead?
- Suma Shivaprasad
On Aug. 4, 2016, 12:19 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50776/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 12:19 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1089
> https://issues.apache.org/jira/browse/ATLAS-1089
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated Storm hook to handle cyclic references in Storm topology object
>
>
> Diffs
> -----
>
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java c4b4976
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java ce6a175
>
> Diff: https://reviews.apache.org/r/50776/diff/
>
>
> Testing
> -------
>
> Validated that Atlas Storm hook gracefully handles cyclic references in Storm topology object, using a test topology implementation.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>