You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/07/28 05:36:53 UTC
[GitHub] [dubbo] EarthChen opened a new pull request, #10381: [3.1-Triple] remove tri dubbo-compiler-version propertie
EarthChen opened a new pull request, #10381:
URL: https://github.com/apache/dubbo/pull/10381
## What is the purpose of the change
## Brief changelog
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #10381: [3.1-Triple] remove tri dubbo-compiler-version properties
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10381:
URL: https://github.com/apache/dubbo/pull/10381#issuecomment-1197718231
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/10381?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10381](https://codecov.io/gh/apache/dubbo/pull/10381?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4665d6b) into [3.1](https://codecov.io/gh/apache/dubbo/commit/f9eb28cf7ebb16e45c858c20982690b5a991a04d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9eb28c) will **decrease** coverage by `0.72%`.
> The diff coverage is `27.60%`.
> :exclamation: Current head 4665d6b differs from pull request most recent head ac28d06. Consider uploading reports for the commit ac28d06 to get more accurate results
```diff
@@ Coverage Diff @@
## 3.1 #10381 +/- ##
============================================
- Coverage 65.54% 64.81% -0.73%
+ Complexity 318 293 -25
============================================
Files 1248 1249 +1
Lines 54260 54393 +133
Branches 8192 8203 +11
============================================
- Hits 35564 35255 -309
- Misses 14830 15248 +418
- Partials 3866 3890 +24
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/10381?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/dubbo/common/config/Environment.java](https://codecov.io/gh/apache/dubbo/pull/10381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0Vudmlyb25tZW50LmphdmE=) | `81.45% <ø> (ø)` | |
| [.../apache/dubbo/common/config/ModuleEnvironment.java](https://codecov.io/gh/apache/dubbo/pull/10381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL01vZHVsZUVudmlyb25tZW50LmphdmE=) | `47.29% <ø> (ø)` | |
| [...pache/dubbo/common/json/impl/AbstractJSONImpl.java](https://codecov.io/gh/apache/dubbo/pull/10381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vanNvbi9pbXBsL0Fic3RyYWN0SlNPTkltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/dubbo/pull/10381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RDb25maWcuamF2YQ==) | `77.08% <0.00%> (+5.78%)` | :arrow_up: |
| [...va/org/apache/dubbo/config/context/ConfigMode.java](https://codecov.io/gh/apache/dubbo/pull/10381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvY29udGV4dC9Db25maWdNb2RlLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/10381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `91.39% <ø> (-0.06%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/10381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `79.09% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/metadata/MetadataInfo.java](https://codecov.io/gh/apache/dubbo/pull/10381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9NZXRhZGF0YUluZm8uamF2YQ==) | `76.40% <ø> (-0.29%)` | :arrow_down: |
| [...java/org/apache/dubbo/qos/command/impl/Online.java](https://codecov.io/gh/apache/dubbo/pull/10381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9PbmxpbmUuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...e/dubbo/rpc/cluster/filter/FilterChainBuilder.java](https://codecov.io/gh/apache/dubbo/pull/10381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZmlsdGVyL0ZpbHRlckNoYWluQnVpbGRlci5qYXZh) | `37.69% <16.66%> (-0.41%)` | :arrow_down: |
| ... and [93 more](https://codecov.io/gh/apache/dubbo/pull/10381/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM merged pull request #10381: [3.1-Triple] remove tri dubbo-compiler-version properties
Posted by GitBox <gi...@apache.org>.
CrazyHZM merged PR #10381:
URL: https://github.com/apache/dubbo/pull/10381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org