You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/10 07:01:44 UTC
[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request
#5138: add refresh metadata event after executing ddlstatement.
yu199195 opened a new pull request #5138: add refresh metadata event after executing ddlstatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/5138
Fixes https://github.com/apache/incubator-shardingsphere/issues/5128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #5138: add
refresh metadata event after executing ddlstatement.
Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #5138: add refresh metadata event after executing ddlstatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/5138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #5138: add refresh metadata event after executing ddlstatement.
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5138: add refresh metadata event after executing ddlstatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/5138#discussion_r406660087
##########
File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-facade/src/main/java/org/apache/shardingsphere/orchestration/core/facade/listener/ShardingOrchestrationListenerManager.java
##########
@@ -33,11 +34,14 @@
private final StateChangedListenerManager stateChangedListenerManager;
+ private final MetaDataListenerManager metaDataListenerManager;
+
public ShardingOrchestrationListenerManager(final String registryCenterRepositoryName, final RegistryCenterRepository registryCenterRepository,
Review comment:
add metadata center repository name here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #5138: add refresh metadata event after executing ddlstatement.
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5138: add refresh metadata event after executing ddlstatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/5138#discussion_r406649915
##########
File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/yaml/RuleSchemaMetaDataYamlSwapper.java
##########
@@ -60,6 +61,9 @@ private TableMetaData convertTable(final YamlTableMetaData table) {
}
private Collection<IndexMetaData> convertIndexes(final Map<String, YamlIndexMetaData> indexes) {
+ if(null == indexes){
Review comment:
ternary operator is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services