[GitHub] [iceberg] cccs-eric commented on a change in pull request #3989: Python: MapType missing required methods and visit() not supporting MapType

[GitBox <gi...@apache.org>]

cccs-eric commented on a change in pull request #3989:
URL: https://github.com/apache/iceberg/pull/3989#discussion_r793977478



##########
File path: python_legacy/iceberg/api/types/types.py
##########
@@ -696,6 +696,12 @@ def key_id(self):
     def value_id(self):
         return self.value_field.field_id
 
+    def asMapType(self):

Review comment:
       I fully agree with you, but it is part of the [Type interface](https://github.com/apache/iceberg/blob/master/python_legacy/iceberg/api/types/type.py#L66).  I didn't want to change too much in fear of breaking other code depending on this API.  I can make the change if you like, but not sure if it could create side effects.  Probably nothing major since code already using that interface method are always getting `False`...!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org