You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by hl...@apache.org on 2009/01/12 23:17:14 UTC

svn commit: r733934 - /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js

Author: hlship
Date: Mon Jan 12 14:17:13 2009
New Revision: 733934

URL: http://svn.apache.org/viewvc?rev=733934&view=rev
Log:
TAP5-416: Javascript error with IE and Window Prototype

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js?rev=733934&r1=733933&r2=733934&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js Mon Jan 12 14:17:13 2009
@@ -2086,7 +2086,7 @@
     if (element.offsetParent) return $(element.offsetParent);
     if (element == document.body) return $(element);
 
-    while ((element = element.parentNode) && element != document.body)
+    while ((element = element.parentNode) && element != document.body && element != document) 
       if (Element.getStyle(element, 'position') != 'static')
         return $(element);

Re: svn commit: r733934 - /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js

Posted by Howard Lewis Ship <hl...@gmail.com>.
It looks valid to me; other than that, the prototype.js is 1.6.0.3.

On Tue, Jan 13, 2009 at 1:10 AM, Massimo Lusetti <ml...@gmail.com> wrote:
> On Mon, Jan 12, 2009 at 11:17 PM,  <hl...@apache.org> wrote:
>
>> Author: hlship
>> Date: Mon Jan 12 14:17:13 2009
>> New Revision: 733934
>>
>> URL: http://svn.apache.org/viewvc?rev=733934&view=rev
>> Log:
>> TAP5-416: Javascript error with IE and Window Prototype
>>
>> Modified:
>>    tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js
>
> Does this patch comes from prototype? Or is yours?
>
> --
> Massimo
> http://meridio.blogspot.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>



-- 
Howard M. Lewis Ship

Creator Apache Tapestry and Apache HiveMind

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: svn commit: r733934 - /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js

Posted by Howard Lewis Ship <hl...@gmail.com>.
It came from the patch attached to the issue.

On Tue, Jan 13, 2009 at 1:10 AM, Massimo Lusetti <ml...@gmail.com> wrote:
> On Mon, Jan 12, 2009 at 11:17 PM,  <hl...@apache.org> wrote:
>
>> Author: hlship
>> Date: Mon Jan 12 14:17:13 2009
>> New Revision: 733934
>>
>> URL: http://svn.apache.org/viewvc?rev=733934&view=rev
>> Log:
>> TAP5-416: Javascript error with IE and Window Prototype
>>
>> Modified:
>>    tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js
>
> Does this patch comes from prototype? Or is yours?
>
> --
> Massimo
> http://meridio.blogspot.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>



-- 
Howard M. Lewis Ship

Creator Apache Tapestry and Apache HiveMind

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: svn commit: r733934 - /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js

Posted by Massimo Lusetti <ml...@gmail.com>.
On Mon, Jan 12, 2009 at 11:17 PM,  <hl...@apache.org> wrote:

> Author: hlship
> Date: Mon Jan 12 14:17:13 2009
> New Revision: 733934
>
> URL: http://svn.apache.org/viewvc?rev=733934&view=rev
> Log:
> TAP5-416: Javascript error with IE and Window Prototype
>
> Modified:
>    tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/scriptaculous_1_8_1/prototype.js

Does this patch comes from prototype? Or is yours?

-- 
Massimo
http://meridio.blogspot.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org