You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/12 23:41:59 UTC

[GitHub] [kafka] hachikuji commented on a change in pull request #10309: KAFKA-12181; Loosen raft fetch offset validation of remote replicas

hachikuji commented on a change in pull request #10309:
URL: https://github.com/apache/kafka/pull/10309#discussion_r593509351



##########
File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java
##########
@@ -247,7 +267,7 @@ private boolean isVoter(int remoteNodeId) {
         return voterReplicaStates.containsKey(remoteNodeId);
     }
 
-    private static class ReplicaState implements Comparable<ReplicaState> {
+    private static abstract class ReplicaState implements Comparable<ReplicaState> {

Review comment:
       Good point.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org