You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by woonsan <gi...@git.apache.org> on 2017/02/07 14:35:12 UTC
[GitHub] jmeter pull request #263: Bug 60564 - Migrating LogKit logger to SLF4J logge...
GitHub user woonsan opened a pull request:
https://github.com/apache/jmeter/pull/263
Bug 60564 - Migrating LogKit logger to SLF4J logger - only for components/assertions package.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/jmeter feature/bz60564-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #263
----
commit f012b0001f7b9eaa97ba390e998331a73b2646ce
Author: Woonsan Ko <wo...@apache.org>
Date: 2017-02-07T14:33:43Z
Bug 60564 - Migrating LogKit logger to SLF4J logger - only for
components/assertions package.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #263: Bug 60564 - Migrating LogKit logger to SLF4J logger - onl...
Posted by woonsan <gi...@git.apache.org>.
Github user woonsan commented on the issue:
https://github.com/apache/jmeter/pull/263
@pmouawad I guess I didn't include the condition in case I thought the method call was trivial, but you're totally right. Method call shouldn't be avoided at any case in debug logging. Thank you very much for the pointers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #263: Bug 60564 - Migrating LogKit logger to SLF4J logger - onl...
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/263
Hi Woonsan,
Thanks for the PR.
I just modified few lines, I think I did right, but confirmation is better.
I added log.isDebugEnabled() when parameters of log message called some methods.
Do you agree with this ?
Thanks
Regards
Philippe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #263: Bug 60564 - Migrating LogKit logger to SLF4J logge...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---