You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/23 20:48:11 UTC

[GitHub] [airflow] mcepok opened a new pull request #14967: Fix too specific parsing of `False` in LegacyUIDeprecated

mcepok opened a new pull request #14967:
URL: https://github.com/apache/airflow/pull/14967


   This is one of two issues mentioned in #13287 . The issue is trivial one: only `false` case sensitive was taken into account, however, the Airflow config allows many more options for the boolean False.
   This fix is basically a replacement of the case sensitive check for `false` by the same logic `getboolean()` uses. Using `getboolean()` itself seems not to be a good solution, since it throws an Exception if there is a blank value in the field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb merged pull request #14967: Fix too specific parsing of `False` in LegacyUIDeprecated

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14967:
URL: https://github.com/apache/airflow/pull/14967


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mcepok commented on pull request #14967: Fix too specific parsing of `False` in LegacyUIDeprecated

Posted by GitBox <gi...@apache.org>.
mcepok commented on pull request #14967:
URL: https://github.com/apache/airflow/pull/14967#issuecomment-805554605


   Added some False options in the unittest. No idea why the CI Builds are failing :) .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mcepok commented on pull request #14967: Fix too specific parsing of `False` in LegacyUIDeprecated

Posted by GitBox <gi...@apache.org>.
mcepok commented on pull request #14967:
URL: https://github.com/apache/airflow/pull/14967#issuecomment-808755500


   @jhtimmins can you have another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org