[GitHub] [hadoop] hchaverri commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

[GitBox <gi...@apache.org>]

hchaverri commented on code in PR #4311:
URL: https://github.com/apache/hadoop/pull/4311#discussion_r892717426


##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java:
##########
@@ -40,6 +40,14 @@ public class ClientGSIContext implements AlignmentContext {
   private final LongAccumulator lastSeenStateId =
       new LongAccumulator(Math::max, Long.MIN_VALUE);
 
+  public void disableObserverRead() {
+    if(lastSeenStateId.get() > -1L) {

Review Comment:
   Should we be repurposing the accumulator to define the state? Could -1L be a valid value on the header stateId that might break this? Should we use a boolean instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org