You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/10 23:41:57 UTC
[GitHub] [beam] lostluck opened a new issue, #22211: [Feature Request][Go SDK] Support Key Aware CombineFns
lostluck opened a new issue, #22211:
URL: https://github.com/apache/beam/issues/22211
### What would you like to happen?
It looks like that the CombineFns [documentation indicates that they should support being key aware.](https://pkg.go.dev/github.com/apache/beam/sdks/v2/go/pkg/beam#CombinePerKey)
However, validation doesn't support this style of CombineFn despite the execution code being present to handle it.
https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/combine.go#L39
That it broke and there are no examples or tests, means it's never truly been supported, so this should be treated as a new feature.
Either the documentation and associated code should be cleared up to avoid future misunderstandings, or the feature should be properly implemented and integration tested.
### Issue Priority
Priority: 2
### Issue Component
Component: sdk-go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org