[jira] [Closed] (OFBIZ-5556) Tracking code report in Marketing doesn't work

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-5556.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 13.07
                   Release Branch 12.04
                   SVN trunk
                   Release Branch 11.04
         Assignee: Jacques Le Roux

Hi Rong

I did not use your proposed patch
The problem was simple and due to an error I made in r703816. 
I then replaced
-if (trackingCodeIdStr && !(trackingCodeIdStr.equals(""))) {
by
+if (trackingCodeIdSt) {
which was wrong
Then trying to fix an error reported somewhere (not mentioned) Hans went in a wrong direction with r761539+761541

So I reverted r761539+761541 and fixed the issue above in a clean way by setting the field in the calling screen. This way there are no possible issues with i10n and NPEs.

Commited in 
trunk r1576378  
R13.07 r1576380
R12.04 r1576381
R11.04 r1576382

Thanks for report!

> Tracking code report in Marketing doesn't work
> ----------------------------------------------
>
>                 Key: OFBIZ-5556
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5556
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: SVN trunk
>            Reporter: Rong Nguyen
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04, Release Branch 13.07
>
>         Attachments: Bug-5556.patch
>
>
> Scenario:
> 1. Go to marketing webapp
> 2. Go to Reports
> 3. In "Tracking Code Report", select start data and thru data
> 4. Click "Run Tracking code report"



--
This message was sent by Atlassian JIRA
(v6.2#6252)