You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/01/03 23:09:17 UTC

Re: Review Request: Added helpers to extract resources

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8145/
-----------------------------------------------------------

(Updated Jan. 3, 2013, 10:09 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

addressed benh's comment and rebased off trunk


Description
-------

Added helpers to extract specific resources: cpus,mem, disk and ports.

I wanted these as part of a fix I am going to make to the slave, to properly deal with resources specified via command line.

Hopefully, once we make the resources first class, we don't need these helpers?


Diffs (updated)
-----

  src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
  src/tests/resources_tests.cpp 83e93482a6800724d51aeae91e57d2a2b52b37b6 

Diff: https://reviews.apache.org/r/8145/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request: Added helpers to extract resources

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8145/
-----------------------------------------------------------

(Updated Feb. 26, 2013, 7:56 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

rebased off trunk of posterity.


Description
-------

Added helpers to extract specific resources: cpus,mem, disk and ports.

I wanted these as part of a fix I am going to make to the slave, to properly deal with resources specified via command line.

Hopefully, once we make the resources first class, we don't need these helpers?


Diffs (updated)
-----

  src/common/resources.hpp 7e71a58cb601f1626872baa4908cd5d0d838ca0e 
  src/tests/resources_tests.cpp 83e93482a6800724d51aeae91e57d2a2b52b37b6 

Diff: https://reviews.apache.org/r/8145/diff/


Testing
-------

make check


Thanks,

Vinod Kone