You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Josh McKenzie (Jira)" <ji...@apache.org> on 2022/03/21 16:40:00 UTC
[jira] [Commented] (CASSANDRA-17017) Add required -f / --force option to nodetool verify
[ https://issues.apache.org/jira/browse/CASSANDRA-17017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509998#comment-17509998 ]
Josh McKenzie commented on CASSANDRA-17017:
-------------------------------------------
Ok, ready for review and done wrestling with custom dtest branch on CI:
[C* branch|https://github.com/apache/cassandra/pull/1246/commits]
[dtest PR|https://github.com/josh-mckenzie/cassandra-dtest/commit/fcb07ce9429d7639931e3ab20bcd40a007687fd5]
[CI|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/182/workflows/f759ecea-2f62-49fd-a363-82eb19ced25b]
Notably, [my attempts at getting circle to run w/a custom dtest branch failed|https://github.com/apache/cassandra/pull/1246/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R36-R37] however running {{test_sstableverify}} locally w/the dtest branch works as expected.
> Add required -f / --force option to nodetool verify
> ---------------------------------------------------
>
> Key: CASSANDRA-17017
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17017
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
> Reporter: Josh McKenzie
> Assignee: Josh McKenzie
> Priority: Normal
>
> nodetool verify has some pretty significant problems with it (see CASSANDRA-9947).
> Until such time as we do the heavy(er) lift to fix the command, we should make it harder for people to shoot themselves in the foot with it. Adding a required "-f" flag to it with a requisite "Do you really know what you're doing? Check out this JIRA first" seems like it'd be the right thing to do in the interim.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org