You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2017/10/04 11:23:06 UTC

[GitHub] flink pull request #4746: [FLINK-7657] [Table] Adding logic to convert RexLi...

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4746#discussion_r142632025
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/literals.scala ---
    @@ -49,10 +50,51 @@ object Literal {
         case sqlTime: Time => Literal(sqlTime, SqlTimeTypeInfo.TIME)
         case sqlTimestamp: Timestamp => Literal(sqlTimestamp, SqlTimeTypeInfo.TIMESTAMP)
       }
    +
    +  private[flink] def apply(rexNode: RexLiteral): Literal = {
    --- End diff --
    
    This logic is better located in `RexNodeToExpressionConverter.visitLiteral`.


---