You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/13 05:56:11 UTC

[GitHub] [apisix-ingress-controller] tokers opened a new issue #836: bug: the tranlsation of route with plugin_config is pathological

tokers opened a new issue #836:
URL: https://github.com/apache/apisix-ingress-controller/issues/836


   ### Issue description
   
   https://github.com/apache/apisix-ingress-controller/blob/de522437bd3db3dc3e8d8f33c92f322de67531b8/pkg/kube/translation/apisix_route.go#L534-L539
   
   The code snippet pasted above has two problems:
   
   1). The plugin config id generation should not rely on the name of backend service name, which will cause all routes with the same backend generated with the same plugin config id.
   2). add the plugin_config id reference even if users don't specify the plugin config on the `ApisixRoute` explicitly
   
   ### Environment
   
   - your apisix-ingress-controller version (output of apisix-ingress-controller version --long):
   - your Kubernetes cluster version (output of kubectl version):
   - if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a):
   
   
   ### Minimal test code / Steps to reproduce
   
   Nope.
   
   ### Actual result
   
   Nope.
   
   ### Error log
   
   Nope.
   
   ### Expected result
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on issue #836: bug: the tranlsation of route with plugin_config is pathological

Posted by GitBox <gi...@apache.org>.
neverCase commented on issue #836:
URL: https://github.com/apache/apisix-ingress-controller/issues/836#issuecomment-1011863497


   ok, got it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #836: bug: the tranlsation of route with plugin_config is pathological

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #836:
URL: https://github.com/apache/apisix-ingress-controller/issues/836#issuecomment-1011862363


   cc @neverCase 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org