[jira] [Commented] (DRILL-6093) Unneeded columns in Drill logical project

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328356#comment-16328356 ] 

ASF GitHub Bot commented on DRILL-6093:
---------------------------------------

GitHub user gparai opened a pull request:

    https://github.com/apache/drill/pull/1093

    DRILL-6093 : Account for simple columns in project cpu costing

    @amansinha100 can you please review this PR? Thanks!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gparai/drill DRILL-6093-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1093.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1093
    
----
commit 30f1934e6b57aeaf33f72ac701bd431f2c11e403
Author: Gautam Parai <gp...@...>
Date:   2018-01-16T23:16:16Z

    DRILL-6093 : Account for simple columns in project cpu costing

----


> Unneeded columns in Drill logical project
> -----------------------------------------
>
>                 Key: DRILL-6093
>                 URL: https://issues.apache.org/jira/browse/DRILL-6093
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0, 1.12.0
>            Reporter: Gautam Kumar Parai
>            Assignee: Gautam Kumar Parai
>            Priority: Major
>             Fix For: 1.12.0
>
>
> Here is an example query with the corresponding logical plan. The project contains unnecessary columns L_ORDERKEY, O_ORDERKEY in the projection even when it is not required by subsequent operators e.g. DrillJoinRel.
> EXPLAIN PLAN without implementation FOR SELECT L.L_QUANTITY FROM cp.`tpch/lineitem.parquet` L, cp.`tpch/orders.parquet` O WHERE cast(L.L_ORDERKEY as int) = cast(O.O_ORDERKEY as int);
> *+------+------+*
> *|* *text* *|* *json* *|*
> *+------+------+*
> *|* DrillScreenRel
>   DrillProjectRel(L_QUANTITY=[$1])
>     DrillJoinRel(condition=[=($2, $4)], joinType=[inner])
>       DrillProjectRel(L_ORDERKEY=[$0], L_QUANTITY=[$1], $f2=[CAST($0):INTEGER])
>         DrillScanRel(table=[[cp, tpch/lineitem.parquet]], groupscan=[ParquetGroupScan [entries=[ReadEntryWithPath [path=classpath:/tpch/lineitem.parquet]], selectionRoot=classpath:/tpch/lineitem.parquet, numFiles=1, numRowGroups=1, usedMetadataFile=false, columns=[`L_ORDERKEY`, `L_QUANTITY`]]])
>       DrillProjectRel(O_ORDERKEY=[$0], $f1=[CAST($0):INTEGER])
>         DrillScanRel(table=[[cp, tpch/orders.parquet]], groupscan=[ParquetGroupScan [entries=[ReadEntryWithPath [path=classpath:/tpch/orders.parquet]], selectionRoot=classpath:/tpch/orders.parquet, numFiles=1, numRowGroups=1, usedMetadataFile=false, columns=[`O_ORDERKEY`]]])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)