[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #164: HDDS-426. Add field modificationTime for Volume and Bucket

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #164: HDDS-426. Add field modificationTime for Volume and Bucket
URL: https://github.com/apache/hadoop-ozone/pull/164#discussion_r358358994
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeSetOwnerRequest.java
 ##########
 @@ -153,6 +153,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
 
       // Set owner with new owner name.
       omVolumeArgs.setOwnerName(newOwner);
+      // Update modificationTime.
+      omVolumeArgs.updateModificationTime();
 
 Review comment:
   Modification time should be set in the preExecute, and use the same value in validateAndUpdateCache. why it needs to be done like this is, in HA all OM's will have the same modification time, in this case there is a chance of OM's having different modification time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org