You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/08/21 10:27:13 UTC
[GitHub] flink pull request #4568: [FLINK-7483][blob] prevent cleanup of re-registere...
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4568
[FLINK-7483][blob] prevent cleanup of re-registered jobs
## What is the purpose of the change
Since #4238, when a job is registered but was released before and the ref count hit `0`, its cleanup timeout was not reset. This fixes that and adds more reference-counter tests.
## Brief change log
- reset the cleanup timeout after job re-registration
- add a test for verifying the reference counters contain the expected values
## Verifying this change
This change added a test for verifying reference counter values: `BlobCacheCleanupTest#testJobReferences`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-6916-7057-hotfix2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4568.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4568
----
commit a0a5e2ebf999867462ed31257f30fd777f4fb5f4
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-08-21T08:36:56Z
[FLINK-7483][blob] prevent cleanup of re-registered jobs
When a job is registered, it may have been released before and we thus need to
reset the cleanup timeout again.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4568: [FLINK-7483][blob] prevent cleanup of re-registered jobs
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4568
will be fixed by #4358
---
[GitHub] flink pull request #4568: [FLINK-7483][blob] prevent cleanup of re-registere...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK closed the pull request at:
https://github.com/apache/flink/pull/4568
---
[GitHub] flink issue #4568: [FLINK-7483][blob] prevent cleanup of re-registered jobs
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4568
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4568: [FLINK-7483][blob] prevent cleanup of re-registered jobs
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4568
@tedyu this fixes the two issues you found in #4238. Could you have a quick look, also?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4568: [FLINK-7483][blob] prevent cleanup of re-registered jobs
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4568
FYI: the test instability of `JobManagerCleanupITCase` will be fixed by #4358, the next BLOB-PR in line - I don't want to mess up the following PRs anymore (again) by integrating it separately or here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---