You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2018/08/01 21:34:00 UTC
[jira] [Created] (RATIS-288) Pom cleanup/simplification
Josh Elser created RATIS-288:
--------------------------------
Summary: Pom cleanup/simplification
Key: RATIS-288
URL: https://issues.apache.org/jira/browse/RATIS-288
Project: Ratis
Issue Type: Improvement
Components: build
Reporter: Josh Elser
Assignee: Josh Elser
I'm noticing quite a bit of over-complication in the build, mostly around ratis-proto-shaded. From what I can tell in the git history, this is holdover from quite some time ago (when the module itself was introduced).
Some weird things I see:
* Everything being marked as optional
* Explicit scope=compile being listed (this is the default)
* Inheriting all configuration from the netty-all pom (not sure why we'd want this)
* Recompilation of source files included in ratis-proto-shaded (shade-plugin can do this already)
My only guess is that some of this was to support the {{skipShade}} option. I think I can halve the amount of time for the ratis-proto-shaded model, and still support a workflow that will let folks skip re-compilation if they haven't changed the protobufs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)