[Impala-ASF-CR] IMPALA-14911: Calcite planner: Fix boolean to numeric comparison

["Michael Smith (Code Review)" <ge...@cloudera.org>]

Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24217 )

Change subject: IMPALA-14911: Calcite planner: Fix boolean to numeric comparison
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24217/7/testdata/workloads/functional-query/queries/QueryTest/binary_exprs_with_boolean.test
File testdata/workloads/functional-query/queries/QueryTest/binary_exprs_with_boolean.test:

http://gerrit.cloudera.org:8080/#/c/24217/7/testdata/workloads/functional-query/queries/QueryTest/binary_exprs_with_boolean.test@324
PS7, Line 324: select binary_col = bool_col as a from test_bool_binary_eq order by a;
> This is the "=" case again (line 178) - I think the ">" variant was meant h
I'd be willing to +2 once this comment is addressed.



-- 
To view, visit http://gerrit.cloudera.org:8080/24217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I764dcbd2fd0d1323bfb964ed91d94cd3def594c0
Gerrit-Change-Number: 24217
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Sep 2026 18:40:52 +0000
Gerrit-HasComments: Yes