You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/07 22:53:33 UTC
[GitHub] [superset] justinpark opened a new pull request, #21741: fix(sqllab): resultset disappeared on switching tabs
justinpark opened a new pull request, #21741:
URL: https://github.com/apache/superset/pull/21741
### SUMMARY
Since the rendering refactoring by #20877, the number of redundant rendering reduced.
The FilterableTable re-rendering reduced related to the unnecessary property update but it wasn't reloaded when height is updated. This occurs the empty result-set problem due to react-virtualized rendering issue with `NaN` height value.
This commit fixes the rendering issue with the updated height value.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
- Before
https://user-images.githubusercontent.com/1392866/194672139-106af5f1-718f-44a4-a3a4-f70433f53642.mov
- After
https://user-images.githubusercontent.com/1392866/194672137-58aa31ed-6b9d-4aac-b123-a26eb81df189.mov
### TESTING INSTRUCTIONS
- Go to SqlLab
- Open 2 tabs in UI
- Run query in 1 and wait for results to show
- Switch to other tab, then back to original tab
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #21741: fix(sqllab): resultset disappeared on switching tabs
Posted by GitBox <gi...@apache.org>.
ktmud merged PR #21741:
URL: https://github.com/apache/superset/pull/21741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21741: fix(sqllab): resultset disappeared on switching tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21741:
URL: https://github.com/apache/superset/pull/21741#issuecomment-1272169492
# [Codecov](https://codecov.io/gh/apache/superset/pull/21741?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21741](https://codecov.io/gh/apache/superset/pull/21741?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (15d0314) into [master](https://codecov.io/gh/apache/superset/commit/0c461497ff0ab3cb5a96d68cc919b73a921cae66?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0c46149) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 15d0314 differs from pull request most recent head fcefb26. Consider uploading reports for the commit fcefb26 to get more accurate results
```diff
@@ Coverage Diff @@
## master #21741 +/- ##
=======================================
Coverage 66.84% 66.84%
=======================================
Files 1800 1800
Lines 68940 68942 +2
Branches 7334 7334
=======================================
+ Hits 46084 46086 +2
Misses 20964 20964
Partials 1892 1892
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.16% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/FilterableTable/index.tsx](https://codecov.io/gh/apache/superset/pull/21741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL2luZGV4LnRzeA==) | `72.91% <100.00%> (+0.28%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #21741: fix(sqllab): resultset disappeared on switching tabs
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #21741:
URL: https://github.com/apache/superset/pull/21741#issuecomment-1273525707
Can we merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org