You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/02/02 17:20:46 UTC

[GitHub] [parquet-format] gszadovszky opened a new pull request #166: PARQUET-1969: Test by GithubAction

gszadovszky opened a new pull request #166:
URL: https://github.com/apache/parquet-format/pull/166


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-format] pitrou commented on pull request #166: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #166:
URL: https://github.com/apache/parquet-format/pull/166#issuecomment-810130223


   There was a remaining typo in the URL, I've fixed it myself to avoid any spurious back-and-forths.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-format] pitrou commented on a change in pull request #166: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #166:
URL: https://github.com/apache/parquet-format/pull/166#discussion_r603972065



##########
File path: README.md
##########
@@ -17,7 +17,7 @@
   - under the License.
   -->
 
-# Parquet [![Build Status](https://travis-ci.org/apache/parquet-format.png?branch=master)](http://travis-ci.org/apache/parquet-format)
+# Parquet [![Build Status](https://github.com/apache/parquet-format/workflows/Test/badge.svg)](https://github.com/apache/parquet-format/actions)

Review comment:
       I believe the URL should be https://github.com/apache/parquet-format/actions/workflows/test.yml/badge.svg
   
   (see https://github.com/apache/arrow/actions/workflows/cpp.yml/badge.svg for an example on another repo)

##########
File path: .github/workflows/test.yml
##########
@@ -0,0 +1,36 @@
+name: Test
+
+on: [push, pull_request]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ '1.8', '11' ]
+    name: Build Parquet with JDK ${{ matrix.java }} and ${{ matrix.codes }}

Review comment:
       `matrix.codes` doesn't seem to point to anything. Just drop it?
   (see formatted labels in https://github.com/gszadovszky/parquet-format/runs/1816450871 )




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-format] gszadovszky commented on pull request #166: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #166:
URL: https://github.com/apache/parquet-format/pull/166#issuecomment-810243284


   Thanks a lot, @pitrou for the review and fix. I works correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-format] pitrou merged pull request #166: PARQUET-1969: Test by GithubAction

Posted by GitBox <gi...@apache.org>.
pitrou merged pull request #166:
URL: https://github.com/apache/parquet-format/pull/166


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org