You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/15 12:07:18 UTC
[GitHub] [superset] amitmiran137 opened a new pull request #12547: chore: remove # pylint: disable=singleton-comparison
amitmiran137 opened a new pull request #12547:
URL: https://github.com/apache/superset/pull/12547
### SUMMARY
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 closed pull request #12547: chore: remove # pylint: disable=singleton-comparison
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #12547:
URL: https://github.com/apache/superset/pull/12547
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12547: chore: remove # pylint: disable=singleton-comparison
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12547:
URL: https://github.com/apache/superset/pull/12547#discussion_r558616400
##########
File path: superset/security/manager.py
##########
@@ -592,10 +592,8 @@ def clean_perms(self) -> None:
sesh = self.get_session
pvms = sesh.query(PermissionView).filter(
or_(
- PermissionView.permission # pylint: disable=singleton-comparison
- == None,
- PermissionView.view_menu # pylint: disable=singleton-comparison
- == None,
+ PermissionView.permission is None,
+ PermissionView.view_menu is None,
Review comment:
I don't think `is` triggers the SQLA comparator, therefore this might not generate the condition you want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on a change in pull request #12547: chore: remove # pylint: disable=singleton-comparison
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #12547:
URL: https://github.com/apache/superset/pull/12547#discussion_r558808684
##########
File path: superset/security/manager.py
##########
@@ -592,10 +592,8 @@ def clean_perms(self) -> None:
sesh = self.get_session
pvms = sesh.query(PermissionView).filter(
or_(
- PermissionView.permission # pylint: disable=singleton-comparison
- == None,
- PermissionView.view_menu # pylint: disable=singleton-comparison
- == None,
+ PermissionView.permission is None,
+ PermissionView.view_menu is None,
Review comment:
yeah I wanted to see Dialects supports this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12547: chore: remove # pylint: disable=singleton-comparison
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12547:
URL: https://github.com/apache/superset/pull/12547#discussion_r558625162
##########
File path: superset/security/manager.py
##########
@@ -592,10 +592,8 @@ def clean_perms(self) -> None:
sesh = self.get_session
pvms = sesh.query(PermissionView).filter(
or_(
- PermissionView.permission # pylint: disable=singleton-comparison
- == None,
- PermissionView.view_menu # pylint: disable=singleton-comparison
- == None,
+ PermissionView.permission is None,
+ PermissionView.view_menu is None,
Review comment:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12547: chore: remove # pylint: disable=singleton-comparison
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12547:
URL: https://github.com/apache/superset/pull/12547#issuecomment-760942966
# [Codecov](https://codecov.io/gh/apache/superset/pull/12547?src=pr&el=h1) Report
> Merging [#12547](https://codecov.io/gh/apache/superset/pull/12547?src=pr&el=desc) (802a12a) into [master](https://codecov.io/gh/apache/superset/commit/e1eeeebe537a3f5556ce1f75a028a14d2f344bcf?el=desc) (e1eeeeb) will **decrease** coverage by `5.99%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12547?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12547 +/- ##
==========================================
- Coverage 66.73% 60.73% -6.00%
==========================================
Files 1014 529 -485
Lines 49616 19648 -29968
Branches 4839 4839
==========================================
- Hits 33110 11934 -21176
+ Misses 16383 7516 -8867
- Partials 123 198 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.73% <ø> (ø)` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12547?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [672 more](https://codecov.io/gh/apache/superset/pull/12547/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12547?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12547?src=pr&el=footer). Last update [e1eeeeb...9be9d60](https://codecov.io/gh/apache/superset/pull/12547?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org