You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:02:32 UTC
[GitHub] [incubator-kvrocks] aleksraiden opened a new issue, #941: Github deprecated Ubuntu-18.04 in CI builds.
aleksraiden opened a new issue, #941:
URL: https://github.com/apache/incubator-kvrocks/issues/941
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
### Motivation
See [GitHub Actions: The Ubuntu 18.04 Actions runner image is being deprecated and will be removed by 12/1/22](https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/)
### Solution
So, maybe we can:
- start to migrate on next version of Ubuntu base images (20.04)
- add Ubuntu 22.04 as second images into matrix
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #941: Github deprecated Ubuntu-18.04 in CI builds.
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #941:
URL: https://github.com/apache/incubator-kvrocks/issues/941#issuecomment-1265587138
> I noticed that there has been an [issue](https://github.com/apache/incubator-kvrocks/issues/800) proposing to replace cpplint with `clang-*`, raised by @PragmaTwice . If you have time, you can try using `clang-*` by the way to solve this problem.
Switching to `clang-*` can be a work involving so many code changes and discussions, I suggest we can remain cpplint in this PR if you want to keep the changes minimal. And it may take the focus away from the content of this issue and make it more difficult to merge.
But feel free to try replacing the current cpplint and cppcheck with `clang-*` in other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #941: Github deprecated Ubuntu-18.04 in CI builds.
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #941:
URL: https://github.com/apache/incubator-kvrocks/issues/941#issuecomment-1265590369
You can try to modify the current flags used in cpplint here: https://github.com/apache/incubator-kvrocks/blob/unstable/x.py#L119-L123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] torwig commented on issue #941: Github deprecated Ubuntu-18.04 in CI builds.
Posted by GitBox <gi...@apache.org>.
torwig commented on issue #941:
URL: https://github.com/apache/incubator-kvrocks/issues/941#issuecomment-1265604831
@aleksraiden Sure, I'll help you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on issue #941: Github deprecated Ubuntu-18.04 in CI builds.
Posted by GitBox <gi...@apache.org>.
aleksraiden commented on issue #941:
URL: https://github.com/apache/incubator-kvrocks/issues/941#issuecomment-1265592812
@torwig could we doing here? I will prepare a PR with updated Ubuntu, but cpp* is on your side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tanruixiang commented on issue #941: Github deprecated Ubuntu-18.04 in CI builds.
Posted by GitBox <gi...@apache.org>.
tanruixiang commented on issue #941:
URL: https://github.com/apache/incubator-kvrocks/issues/941#issuecomment-1265562679
> At now, a default ubuntu-latest images changed to 20.04, so cpplint not working now. In cooperation with @Torvig working to fix them
I noticed that there has been an [issue](https://github.com/apache/incubator-kvrocks/issues/800) proposing to replace cpplint with `clang-*`, raised by @PragmaTwice . If you have time, you can try using `clang-*` by the way to solve this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #941: Github deprecated Ubuntu-18.04 in CI builds.
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #941:
URL: https://github.com/apache/incubator-kvrocks/issues/941#issuecomment-1265535902
I also noticed the problem, feel free to open a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on issue #941: Github deprecated Ubuntu-18.04 in CI builds.
Posted by GitBox <gi...@apache.org>.
aleksraiden commented on issue #941:
URL: https://github.com/apache/incubator-kvrocks/issues/941#issuecomment-1265363824
I have tested it in private fork, all builds and tests passed OK. Try to add Ubuntu 22.04 into matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on issue #941: Github deprecated Ubuntu-18.04 in CI builds.
Posted by GitBox <gi...@apache.org>.
aleksraiden commented on issue #941:
URL: https://github.com/apache/incubator-kvrocks/issues/941#issuecomment-1265320785
Also, tcl will be upgraded to 8.6 (default in Ubuntu 20.04 and above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on issue #941: Github deprecated Ubuntu-18.04 in CI builds.
Posted by GitBox <gi...@apache.org>.
aleksraiden commented on issue #941:
URL: https://github.com/apache/incubator-kvrocks/issues/941#issuecomment-1265398743
At now, a default ubuntu-latest images changed to 20.04, so cpplint not working now. In cooperation with @torvig working to fix them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org