[GitHub] [james-project] vttranlina commented on a diff in pull request #1471: JAMES-3893 Add a WebAdmin API allowing creation/updation user identity

["vttranlina (via GitHub)" <gi...@apache.org>]

vttranlina commented on code in PR #1471:
URL: https://github.com/apache/james-project/pull/1471#discussion_r1122843606


##########
server/protocols/webadmin/webadmin-jmap/src/main/java/org/apache/james/webadmin/data/jmap/dto/UserIdentity.java:
##########
@@ -113,6 +131,43 @@ public UserIdentity(String name, String email, String id,
         this.replyTo = replyTo;
     }
 
+    @JsonCreator
+    public UserIdentity(@JsonProperty("name") String name,

Review Comment:
   > why there is no mayDelete field 
   
   The current API does not accept input `mayDelete` field
   
   Quote:
   ```
   org.apache.james.jmap.api.identity.IdentityRepository#save
   mayDelete alway is TRUE
   ```
   
   Should we modify it for web-admin case?
   
   > I would see more this as a UserIdentityCreate or something similar
   
   Yes, it will be clear if we have a separate object `UserIdentityCreate` / `UserIdentiteUpdate`,
   But, IMO, it is simple pojo, we can re-use it in a single object `UserIdentity`, less boilerplate. 
   So, I didn't create UserIdentityCreate...
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org