You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/25 22:40:33 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #9024:
Propose cache type simple
dpgaspar opened a new pull request #9024: Propose cache type simple
URL: https://github.com/apache/incubator-superset/pull/9024
### CATEGORY
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Seems like #9019 makes startup fail on a default configuration. Tests pass because they set cache to simple. We can revert/fix #9019 or change cache default to simple (assuming it's limitations): https://flask-caching.readthedocs.io/en/latest/#simplecache
Startup error:
```
class PrestoEngineSpec(BaseEngineSpec):
File "/home/dpgaspar/workarea/preset/preset_fork_superset/superset/db_engine_specs/presto.py", line 950, in PrestoEngineSpec
@cache.memoize()
File "/home/dpgaspar/workarea/preset/v_superset/lib/python3.6/site-packages/werkzeug/local.py", line 348, in __getattr__
return getattr(self._get_current_object(), name)
AttributeError: 'NoneType' object has no attribute 'memoize'
```
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9024: Propose
cache type simple
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9024: Propose cache type simple
URL: https://github.com/apache/incubator-superset/pull/9024#issuecomment-578450313
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9024?src=pr&el=h1) Report
> Merging [#9024](https://codecov.io/gh/apache/incubator-superset/pull/9024?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c552c852cdb12392ebbc3024b36d328774b53606?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9024?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9024 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 367 367
Lines 11686 11686
Branches 2866 2866
=======================================
Hits 6913 6913
Misses 4594 4594
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9024?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9024?src=pr&el=footer). Last update [c552c85...106ae7a](https://codecov.io/gh/apache/incubator-superset/pull/9024?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #9024: Propose
cache type simple
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #9024: Propose cache type simple
URL: https://github.com/apache/incubator-superset/pull/9024#issuecomment-578449922
Closing, only saw #9020 now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar closed pull request #9024: Propose
cache type simple
Posted by GitBox <gi...@apache.org>.
dpgaspar closed pull request #9024: Propose cache type simple
URL: https://github.com/apache/incubator-superset/pull/9024
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org