[GitHub] [airflow] dimberman commented on a change in pull request #11693: Add Python Helm testing framework

[GitBox <gi...@apache.org>]

dimberman commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r510568399



##########
File path: chart_tests/test_templates/git_sync_scheduler/git-sync-existing-claim.yaml
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+dags:
+ persistence:
+  enabled: true
+  existingClaim: test-claim

Review comment:
       @ashb @mik-laj @kaxil  I moved the configurations into the python files, but I think there could be value here in keeping them as yaml strings as it gives a better 1:1 comparison to an actual launch of the helm chart. Would like feedback though.

##########
File path: .dockerignore
##########
@@ -45,6 +45,7 @@
 # Add tests and kubernetes_tests to context.
 !tests
 !kubernetes_tests
+!chart_tests

Review comment:
       moved to chart/tests




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org