[GitHub] [incubator-druid] himanshug commented on a change in pull request #7765: Fix LookupSerdeModule double-binding in Coordinator-as-Overlord mode.

[GitBox <gi...@apache.org>]

himanshug commented on a change in pull request #7765: Fix LookupSerdeModule double-binding in Coordinator-as-Overlord mode.
URL: https://github.com/apache/incubator-druid/pull/7765#discussion_r288242770
 
 

 ##########
 File path: services/src/main/java/org/apache/druid/cli/CliCoordinator.java
 ##########
 @@ -272,10 +272,12 @@ public LoadQueueTaskMaster getLoadQueueTaskMaster(
         }
     );
 
-    modules.add(new LookupSerdeModule());
-
     if (beOverlord) {
       modules.addAll(new CliOverlord().getModules(false));
+    } else {
+      // Only add LookupSerdeModule if !beOverlord, since CliOverlord includes it, and having two copies causes
+      // the injector to get confused due to having multiple bindings for the same classes.
+      modules.add(new LookupSerdeModule());
 
 Review comment:
   that is why `CliOverloard.getModules(boolean standalone)` takes the standalone flag also, so that we can take care of these things in there if/when needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org