You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Eugene Koifman (JIRA)" <ji...@apache.org> on 2017/11/21 01:43:00 UTC

[jira] [Updated] (HIVE-18110) OrcInputFormat.combineOrCreateETLStrategy() doesn't combine if there are deltas

     [ https://issues.apache.org/jira/browse/HIVE-18110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugene Koifman updated HIVE-18110:
----------------------------------
    Description: 
this method has 
{noformat}
    if (!deltas.isEmpty() || combinedCtx == null) {
      //why is this checking for deltas.isEmpty() - is this Acid 1.0 remnant?
      return new ETLSplitStrategy(
          context, fs, dir, files, readerTypes, isOriginal, deltas, covered, ugi,
          allowSyntheticFileIds, isDefaultFs);
    } else
{noformat}

what is the purpose of checking deltas?  (here with Acid 2.0 deltas is delete deltas)
Is this some remnant of Acid 1.0?

Also see TestInputOutputFormat.testEtlCombinedStrategy

  was:
this method has 
{noformat}
    if (!deltas.isEmpty() || combinedCtx == null) {
      //why is this checking for deltas.isEmpty() - is this Acid 1.0 remnant?
      return new ETLSplitStrategy(
          context, fs, dir, files, readerTypes, isOriginal, deltas, covered, ugi,
          allowSyntheticFileIds, isDefaultFs);
    } else
{noformat}

what is the purpose of checking deltas?  (here with Acid 2.0 deltas is delete deltas)
Is this some remnant of Acid 1.0?


> OrcInputFormat.combineOrCreateETLStrategy() doesn't combine if there are deltas
> -------------------------------------------------------------------------------
>
>                 Key: HIVE-18110
>                 URL: https://issues.apache.org/jira/browse/HIVE-18110
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>
> this method has 
> {noformat}
>     if (!deltas.isEmpty() || combinedCtx == null) {
>       //why is this checking for deltas.isEmpty() - is this Acid 1.0 remnant?
>       return new ETLSplitStrategy(
>           context, fs, dir, files, readerTypes, isOriginal, deltas, covered, ugi,
>           allowSyntheticFileIds, isDefaultFs);
>     } else
> {noformat}
> what is the purpose of checking deltas?  (here with Acid 2.0 deltas is delete deltas)
> Is this some remnant of Acid 1.0?
> Also see TestInputOutputFormat.testEtlCombinedStrategy



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)