You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "no1wudi (via GitHub)" <gi...@apache.org> on 2023/09/15 09:51:45 UTC
[GitHub] [nuttx-apps] no1wudi opened a new pull request, #2066: libuv: Upgrade to v1.46.0
no1wudi opened a new pull request, #2066:
URL: https://github.com/apache/nuttx-apps/pull/2066
## Summary
libuv: Upgrade to v1.46.0
Rebase the porting code on v1.46.0
## Impact
Minor
## Testing
tested with sim:adb, may not stable enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on pull request #2066: libuv: Upgrade to v1.46.0
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #2066:
URL: https://github.com/apache/nuttx-apps/pull/2066#issuecomment-1722496764
let me download your patch and try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on pull request #2066: libuv: Upgrade to v1.46.0
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #2066:
URL: https://github.com/apache/nuttx-apps/pull/2066#issuecomment-1722550543
The other error is related to functionality that is not supported on OSX. So above fix should be enough to pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #2066: libuv: Upgrade to v1.46.0
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #2066:
URL: https://github.com/apache/nuttx-apps/pull/2066#discussion_r1328131779
##########
system/libuv/Makefile:
##########
@@ -72,6 +72,7 @@ CSRCS += core.c
CSRCS += poll.c
CSRCS += loop.c
CSRCS += thread.c
+CSRCS += thread-common.c
Review Comment:
Need to add `CSRCS += strtok.c` after `CSRCS += strscpy.c` before `endif`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on pull request #2066: libuv: Upgrade to v1.46.0
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #2066:
URL: https://github.com/apache/nuttx-apps/pull/2066#issuecomment-1722553322
BTW, strange that the same link error is not reported with Linux `sim:lua` config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on pull request #2066: libuv: Upgrade to v1.46.0
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #2066:
URL: https://github.com/apache/nuttx-apps/pull/2066#issuecomment-1721640302
Please fix
```
Undefined symbols for architecture x86_64:
"_uv__strtok", referenced from:
_uv__search_path in nuttx.rel
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [nuttx] Error 1
make: *** [nuttx] Error 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #2066: libuv: Upgrade to v1.46.0
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2066:
URL: https://github.com/apache/nuttx-apps/pull/2066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] no1wudi commented on pull request #2066: libuv: Upgrade to v1.46.0
Posted by "no1wudi (via GitHub)" <gi...@apache.org>.
no1wudi commented on PR #2066:
URL: https://github.com/apache/nuttx-apps/pull/2066#issuecomment-1722500126
> let me download your patch and try
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] no1wudi commented on pull request #2066: libuv: Upgrade to v1.46.0
Posted by "no1wudi (via GitHub)" <gi...@apache.org>.
no1wudi commented on PR #2066:
URL: https://github.com/apache/nuttx-apps/pull/2066#issuecomment-1722495705
Emm, I don't have such a development environment (x86 base Mac), and can't find where the `_uv__strtok` defined and called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org