You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Shyam Sundar Sarkar (JIRA)" <ji...@apache.org> on 2009/02/05 00:15:02 UTC
[jira] Created: (HIVE-272) Eliminate @Override directives for
classes in Eclipse 3.4.1
Eliminate @Override directives for classes in Eclipse 3.4.1
-----------------------------------------------------------
Key: HIVE-272
URL: https://issues.apache.org/jira/browse/HIVE-272
Project: Hadoop Hive
Issue Type: Improvement
Components: Build Infrastructure
Environment: Eclipse 3.4.1
Reporter: Shyam Sundar Sarkar
Eclipse Versions prior to 3.4.1 actually add @Override to classes which
implement interfaces. Version 3.4.1 correctly complains that @Override
should not be present for methods from interfaces.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-272) Eliminate @Override directives for
classes in Eclipse 3.4.1
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670843#action_12670843 ]
Zheng Shao commented on HIVE-272:
---------------------------------
In Eclipse Preferences Pane go to Java -> Compiler -> Compliance Level, set to Java 1.6.
Then Eclipse does not complain with @Override for that case.
Or you mean Java standard says there should not be an @Override for that case?
> Eliminate @Override directives for classes in Eclipse 3.4.1
> -----------------------------------------------------------
>
> Key: HIVE-272
> URL: https://issues.apache.org/jira/browse/HIVE-272
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Affects Versions: 0.2.0
> Environment: Eclipse 3.4.1
> Reporter: Shyam Sundar Sarkar
> Assignee: Raghotham Murthy
> Fix For: 0.3.0
>
> Attachments: hive-272.1.patch
>
>
> Eclipse Versions prior to 3.4.1 actually add @Override to classes which
> implement interfaces. Version 3.4.1 correctly complains that @Override
> should not be present for methods from interfaces.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-272) Eliminate @Override directives for
classes in Eclipse 3.4.1
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy updated HIVE-272:
----------------------------------
Fix Version/s: 0.3.0
Affects Version/s: 0.2.0
Release Note: Removed @Override to be compatible with eclipse versions greater than 3.4.1. (was: Eclipse 3.4.1 requirements for @Override directives.)
Status: Patch Available (was: Open)
> Eliminate @Override directives for classes in Eclipse 3.4.1
> -----------------------------------------------------------
>
> Key: HIVE-272
> URL: https://issues.apache.org/jira/browse/HIVE-272
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Affects Versions: 0.2.0
> Environment: Eclipse 3.4.1
> Reporter: Shyam Sundar Sarkar
> Assignee: Raghotham Murthy
> Fix For: 0.3.0
>
> Attachments: hive-272.1.patch
>
>
> Eclipse Versions prior to 3.4.1 actually add @Override to classes which
> implement interfaces. Version 3.4.1 correctly complains that @Override
> should not be present for methods from interfaces.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-272) Eliminate @Override directives for
classes in Eclipse 3.4.1
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy updated HIVE-272:
----------------------------------
Attachment: hive-272.1.patch
removed @Override
> Eliminate @Override directives for classes in Eclipse 3.4.1
> -----------------------------------------------------------
>
> Key: HIVE-272
> URL: https://issues.apache.org/jira/browse/HIVE-272
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Eclipse 3.4.1
> Reporter: Shyam Sundar Sarkar
> Attachments: hive-272.1.patch
>
>
> Eclipse Versions prior to 3.4.1 actually add @Override to classes which
> implement interfaces. Version 3.4.1 correctly complains that @Override
> should not be present for methods from interfaces.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-272) Eliminate @Override directives for
classes in Eclipse 3.4.1
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy updated HIVE-272:
----------------------------------
Resolution: Invalid
Status: Resolved (was: Patch Available)
There seems to be quite a bit of confusion about changing the meaning of @Override between 1.5 and 1.6.
See: http://blogs.sun.com/ahe/?entry=override
But, the conclusion is that its ok in 1.6 to specify @Override to methods inherited from interfaces. So, this jira can be closed.
We do need to make a change to our eclipse-templates to make sure that eclipse has java compiler compliance level set to 1.6.
> Eliminate @Override directives for classes in Eclipse 3.4.1
> -----------------------------------------------------------
>
> Key: HIVE-272
> URL: https://issues.apache.org/jira/browse/HIVE-272
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Affects Versions: 0.2.0
> Environment: Eclipse 3.4.1
> Reporter: Shyam Sundar Sarkar
> Assignee: Raghotham Murthy
> Fix For: 0.3.0
>
> Attachments: hive-272.1.patch
>
>
> Eclipse Versions prior to 3.4.1 actually add @Override to classes which
> implement interfaces. Version 3.4.1 correctly complains that @Override
> should not be present for methods from interfaces.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-272) Eliminate @Override directives for
classes in Eclipse 3.4.1
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy reassigned HIVE-272:
-------------------------------------
Assignee: Raghotham Murthy
> Eliminate @Override directives for classes in Eclipse 3.4.1
> -----------------------------------------------------------
>
> Key: HIVE-272
> URL: https://issues.apache.org/jira/browse/HIVE-272
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Eclipse 3.4.1
> Reporter: Shyam Sundar Sarkar
> Assignee: Raghotham Murthy
> Attachments: hive-272.1.patch
>
>
> Eclipse Versions prior to 3.4.1 actually add @Override to classes which
> implement interfaces. Version 3.4.1 correctly complains that @Override
> should not be present for methods from interfaces.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.