You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2011/06/27 23:24:48 UTC

[jira] [Created] (OPENEJB-1620) servlet and filter mapping url-patterns should not have whitespace collapsed

servlet and filter mapping url-patterns should not have whitespace collapsed
----------------------------------------------------------------------------

                 Key: OPENEJB-1620
                 URL: https://issues.apache.org/jira/browse/OPENEJB-1620
             Project: OpenEJB
          Issue Type: Bug
          Components: deployment
    Affects Versions: 4.0
            Reporter: David Jencks
            Assignee: David Jencks
             Fix For: 4.0


The spec says that servlet and filter mapping url-patterns shouldn't have line breaks inside them.  In order to check this we can't collapse the internal whitespace with the CollapsedStringAdapter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OPENEJB-1620) servlet and filter mapping url-patterns should not have whitespace collapsed

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENEJB-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059012#comment-13059012 ] 

Shawn Jiang commented on OPENEJB-1620:
--------------------------------------

Thanks, Rex !  @1142185

> servlet and filter mapping url-patterns should not have whitespace collapsed
> ----------------------------------------------------------------------------
>
>                 Key: OPENEJB-1620
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1620
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: deployment
>    Affects Versions: 4.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 4.0
>
>         Attachments: OPENEJB-1620-another.patch, OPENEJB-1620-jspPropertyGroup.patch
>
>
> The spec says that servlet and filter mapping url-patterns shouldn't have line breaks inside them.  In order to check this we can't collapse the internal whitespace with the CollapsedStringAdapter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OPENEJB-1620) servlet and filter mapping url-patterns should not have whitespace collapsed

Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rex Wang updated OPENEJB-1620:
------------------------------

    Attachment: OPENEJB-1620-jspPropertyGroup.patch

jspPropertyGroup also has the urlpattern...

> servlet and filter mapping url-patterns should not have whitespace collapsed
> ----------------------------------------------------------------------------
>
>                 Key: OPENEJB-1620
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1620
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: deployment
>    Affects Versions: 4.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 4.0
>
>         Attachments: OPENEJB-1620-another.patch, OPENEJB-1620-jspPropertyGroup.patch
>
>
> The spec says that servlet and filter mapping url-patterns shouldn't have line breaks inside them.  In order to check this we can't collapse the internal whitespace with the CollapsedStringAdapter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OPENEJB-1620) servlet and filter mapping url-patterns should not have whitespace collapsed

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENEJB-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056256#comment-13056256 ] 

David Jencks commented on OPENEJB-1620:
---------------------------------------

good idea! rev 1140402

> servlet and filter mapping url-patterns should not have whitespace collapsed
> ----------------------------------------------------------------------------
>
>                 Key: OPENEJB-1620
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1620
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: deployment
>    Affects Versions: 4.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 4.0
>
>         Attachments: OPENEJB-1620-another.patch
>
>
> The spec says that servlet and filter mapping url-patterns shouldn't have line breaks inside them.  In order to check this we can't collapse the internal whitespace with the CollapsedStringAdapter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OPENEJB-1620) servlet and filter mapping url-patterns should not have whitespace collapsed

Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rex Wang updated OPENEJB-1620:
------------------------------

    Attachment: OPENEJB-1620-another.patch

I think should also add this to WebResourceCollection.java

> servlet and filter mapping url-patterns should not have whitespace collapsed
> ----------------------------------------------------------------------------
>
>                 Key: OPENEJB-1620
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1620
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: deployment
>    Affects Versions: 4.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 4.0
>
>         Attachments: OPENEJB-1620-another.patch
>
>
> The spec says that servlet and filter mapping url-patterns shouldn't have line breaks inside them.  In order to check this we can't collapse the internal whitespace with the CollapsedStringAdapter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (OPENEJB-1620) servlet and filter mapping url-patterns should not have whitespace collapsed

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks resolved OPENEJB-1620.
-----------------------------------

    Resolution: Fixed

rev 1140328

> servlet and filter mapping url-patterns should not have whitespace collapsed
> ----------------------------------------------------------------------------
>
>                 Key: OPENEJB-1620
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1620
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: deployment
>    Affects Versions: 4.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 4.0
>
>
> The spec says that servlet and filter mapping url-patterns shouldn't have line breaks inside them.  In order to check this we can't collapse the internal whitespace with the CollapsedStringAdapter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira