[GitHub] [ozone] errose28 commented on pull request #2917: HDDS-6064. `ozone debug ldb` should print proper JSON with `--with-keys=true`

[GitBox <gi...@apache.org>]

errose28 commented on PR #2917:
URL: https://github.com/apache/ozone/pull/2917#issuecomment-1127920585

   Hi @adoroszlai thanks for picking this back up. I think this patch needs some more work. Changing `->` to `:` is still not valid json. Piping the output to jq gives `parse error: Expected string key before ':' at line 1, column 8`. I think we should wrap the whole `withKeys` output block in a dictionary `{}` with commas between entries.
   
   Some additional fixes are still outstanding as well:
   - Modify TestOmDBCli to send all stdout to a different stream, and read this into gson to test that it is valid json.
   - Send all DBScanner scanner output that isn't json (like the 'added definition ...' output) to stderr
   - Flag change mentioned [here](https://github.com/apache/ozone/pull/2917#discussion_r793977007)
       - This may be a problem with the new compatibility guarantees we have discussed, but IMO debug commands are intended for developers to use on the fly, not for end users to put in scripts, so they should allow looser compatibility requirements.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org