You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/06/17 02:41:07 UTC
[Impala-ASF-CR] IMPALA-9862: Don't exclude Solr dependencies in frontend build
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16089
Change subject: IMPALA-9862: Don't exclude Solr dependencies in frontend build
......................................................................
IMPALA-9862: Don't exclude Solr dependencies in frontend build
Ranger can be configured in a variety of ways and some
have a runtime dependency on Solr. If Solr is excluded,
then Impala can fail to startup due to ClassNotFoundException
for org.apache.solr.SolrException.
This removes the exclusion for Solr from fe/pom.xml.
Testing:
- Tests on a cluster that previously failed with ClassNotFoundException
now pass.
Change-Id: Ifb74c20a56e5795cba2efbe887d32392af4017f3
---
M fe/pom.xml
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/16089/1
--
To view, visit http://gerrit.cloudera.org:8080/16089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb74c20a56e5795cba2efbe887d32392af4017f3
Gerrit-Change-Number: 16089
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9862: Don't exclude Solr dependencies in frontend build
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16089 )
Change subject: IMPALA-9862: Don't exclude Solr dependencies in frontend build
......................................................................
Patch Set 2: Code-Review+2
Rebased to get past IMPALA-9842, carry +2
--
To view, visit http://gerrit.cloudera.org:8080/16089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb74c20a56e5795cba2efbe887d32392af4017f3
Gerrit-Change-Number: 16089
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 15:01:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9862: Don't exclude Solr dependencies in frontend build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16089 )
Change subject: IMPALA-9862: Don't exclude Solr dependencies in frontend build
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb74c20a56e5795cba2efbe887d32392af4017f3
Gerrit-Change-Number: 16089
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 20:04:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9862: Don't exclude Solr dependencies in frontend build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16089 )
Change subject: IMPALA-9862: Don't exclude Solr dependencies in frontend build
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6016/
--
To view, visit http://gerrit.cloudera.org:8080/16089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb74c20a56e5795cba2efbe887d32392af4017f3
Gerrit-Change-Number: 16089
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 10:15:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9862: Don't exclude Solr dependencies in frontend build
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16089 )
Change subject: IMPALA-9862: Don't exclude Solr dependencies in frontend build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb74c20a56e5795cba2efbe887d32392af4017f3
Gerrit-Change-Number: 16089
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 04:56:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9862: Don't exclude Solr dependencies in frontend build
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16089 )
Change subject: IMPALA-9862: Don't exclude Solr dependencies in frontend build
......................................................................
IMPALA-9862: Don't exclude Solr dependencies in frontend build
Ranger can be configured in a variety of ways and some
have a runtime dependency on Solr. If Solr is excluded,
then Impala can fail to startup due to ClassNotFoundException
for org.apache.solr.SolrException.
This removes the exclusion for Solr from fe/pom.xml.
Testing:
- Tests on a cluster that previously failed with ClassNotFoundException
now pass.
Change-Id: Ifb74c20a56e5795cba2efbe887d32392af4017f3
Reviewed-on: http://gerrit.cloudera.org:8080/16089
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/pom.xml
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb74c20a56e5795cba2efbe887d32392af4017f3
Gerrit-Change-Number: 16089
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9862: Don't exclude Solr dependencies in frontend build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16089 )
Change subject: IMPALA-9862: Don't exclude Solr dependencies in frontend build
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6344/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb74c20a56e5795cba2efbe887d32392af4017f3
Gerrit-Change-Number: 16089
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 03:06:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9862: Don't exclude Solr dependencies in frontend build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16089 )
Change subject: IMPALA-9862: Don't exclude Solr dependencies in frontend build
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6018/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb74c20a56e5795cba2efbe887d32392af4017f3
Gerrit-Change-Number: 16089
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 15:01:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9862: Don't exclude Solr dependencies in frontend build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16089 )
Change subject: IMPALA-9862: Don't exclude Solr dependencies in frontend build
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6016/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb74c20a56e5795cba2efbe887d32392af4017f3
Gerrit-Change-Number: 16089
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 05:16:46 +0000
Gerrit-HasComments: No