You are viewing a plain text version of this content. The canonical link for it is here.

Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/05/30 08:54:28 UTC

[GitHub] [cassandra] jasonstack commented on a change in pull request #473: Cassandra 15369

jasonstack commented on a change in pull request #473:
URL: https://github.com/apache/cassandra/pull/473#discussion_r432824361



##########
File path: src/java/org/apache/cassandra/db/partitions/AbstractBTreePartition.java
##########
@@ -205,12 +202,17 @@ private RowAndDeletionMergeIterator merge(Iterator<Row> rowIter, Iterator<RangeT
                                                canHaveShadowedData());
     }
 
-    private abstract class AbstractIterator extends AbstractUnfilteredRowIterator
+    private class SlicesIterator extends AbstractUnfilteredRowIterator
     {
         final Holder current;
         final ColumnFilter selection;
 
-        private AbstractIterator(Holder current, Row staticRow, ColumnFilter selection, boolean isReversed)

Review comment:
       good idea.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org