Re： [DISCUSS]Add Vendor Sources Code In SC project

[Sure <su...@qq.com>]

Using glide or dep tool can achieve the effect of generating vendor. 

As sc already used glide to manage package and go mod is still the experimental feature in go 1.11,
 i think there is no need to changed it, we can just push the source code to repo.





------------------ 原始邮件 ------------------
发件人: "Xiaoliang Tian"<xi...@gmail.com>;
发送时间: 2018年8月25日(星期六) 晚上6:02
收件人: "dev"<de...@servicecomb.apache.org>;

主题: Re: [DISCUSS]Add Vendor Sources Code In SC project



I have tired go mod today, it is a good tool. consider about it

glide is never a option, because it is recommending user to use dep.

Mohammad Asif Siddiqui <as...@apache.org> 于2018年8月25日周六 下午5:57写道：

> +1
>
> We can add the vendor to SC folder, this will ease out the development of
> SC specially in China region where GFC blocks the downloading of google
> libs.
>
> Regards
> Asif
>
>
> On Sat, 25 Aug 2018, 3:22 pm Yang Bo, <oa...@gmail.com> wrote:
>
> > +1
> >
> > As for the Apache compliance, It's OK to include the vendor source code
> in
> > our repository. We can update the release script and exclude the vendor
> > directory when releasing.
> >
> > On Sat, Aug 25, 2018 at 4:20 PM Kirin Wang <wa...@gmail.com>
> > wrote:
> >
> > > +1
> > > But may be we need to confirm if there are Apache compliance  issue
> about
> > > it ?
> > >
> > > Xiaoliang Tian <xi...@gmail.com> 于2018年8月25日周六 上午10:48写道：
> > >
> > > > +1  Agree
> > > > the truth is go project can easily go into a dep hell and there is no
> > dep
> > > > tool can manage the complicated deps
> > > >
> > > > checkout how go project does
> > > > https://github.com/istio/istio/tree/master/vendor
> > > > https://github.com/coreos/etcd/tree/master/vendor
> > > >
> > > > dep management is torturing go developers now
> > > >
> > > > Sure <su...@qq.com> 于2018年8月25日周六 上午10:39写道：
> > > >
> > > > > Developers from China complain it is hard to go get the 3rd depends
> > > > source
> > > > > code of sc.
> > > > > I suggest add these source code in vendor directory in sc project,
> > like
> > > > > Istio and etcd project do.
> > > >
> > >
> >
> >
> > --
> > Best Regards,
> > Yang.
> >
>

Re: [DISCUSS]Add Vendor Sources Code In SC project

[Zen Lin <ze...@gmail.com>]

+1 to include source code into vendor folders, and it is better to update
the release script of excluding the vendor directories at the same time.

Best Regards,
---
Zen Lin
zenlintechnofreak@gmail.com
Focused on Micro Service and Apache ServiceComb


Sure <su...@qq.com> 于2018年8月25日周六 下午10:25写道：

> Using glide or dep tool can achieve the effect of generating vendor.
>
> As sc already used glide to manage package and go mod is still the
> experimental feature in go 1.11,
>  i think there is no need to changed it, we can just push the source code
> to repo.
>
>
>
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "Xiaoliang Tian"<xi...@gmail.com>;
> 发送时间: 2018年8月25日(星期六) 晚上6:02
> 收件人: "dev"<de...@servicecomb.apache.org>;
>
> 主题: Re: [DISCUSS]Add Vendor Sources Code In SC project
>
>
>
> I have tired go mod today, it is a good tool. consider about it
>
> glide is never a option, because it is recommending user to use dep.
>
> Mohammad Asif Siddiqui <as...@apache.org> 于2018年8月25日周六 下午5:57写道：
>
> > +1
> >
> > We can add the vendor to SC folder, this will ease out the development of
> > SC specially in China region where GFC blocks the downloading of google
> > libs.
> >
> > Regards
> > Asif
> >
> >
> > On Sat, 25 Aug 2018, 3:22 pm Yang Bo, <oa...@gmail.com> wrote:
> >
> > > +1
> > >
> > > As for the Apache compliance, It's OK to include the vendor source code
> > in
> > > our repository. We can update the release script and exclude the vendor
> > > directory when releasing.
> > >
> > > On Sat, Aug 25, 2018 at 4:20 PM Kirin Wang <wa...@gmail.com>
> > > wrote:
> > >
> > > > +1
> > > > But may be we need to confirm if there are Apache compliance  issue
> > about
> > > > it ?
> > > >
> > > > Xiaoliang Tian <xi...@gmail.com> 于2018年8月25日周六 上午10:48写道：
> > > >
> > > > > +1  Agree
> > > > > the truth is go project can easily go into a dep hell and there is
> no
> > > dep
> > > > > tool can manage the complicated deps
> > > > >
> > > > > checkout how go project does
> > > > > https://github.com/istio/istio/tree/master/vendor
> > > > > https://github.com/coreos/etcd/tree/master/vendor
> > > > >
> > > > > dep management is torturing go developers now
> > > > >
> > > > > Sure <su...@qq.com> 于2018年8月25日周六 上午10:39写道：
> > > > >
> > > > > > Developers from China complain it is hard to go get the 3rd
> depends
> > > > > source
> > > > > > code of sc.
> > > > > > I suggest add these source code in vendor directory in sc
> project,
> > > like
> > > > > > Istio and etcd project do.
> > > > >
> > > >
> > >
> > >
> > > --
> > > Best Regards,
> > > Yang.
> > >
> >