You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by matrosov-nikita <gi...@git.apache.org> on 2016/10/12 10:42:57 UTC
[GitHub] cordova-lib pull request #501: CB-11951 CB-11990 CB-11967: Respect preferenc...
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/501
CB-11951 CB-11990 CB-11967: Respect preference default values when install plugin
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### What does this PR do?
Respects preference default values when install plugin
### What testing has been done on this change?
Auto test
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-lib CB-11951
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/501.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #501
----
commit 51e171a4a3802fe693de4603a08a3584e302e19c
Author: Nikita Matrosov <ma...@gmail.com>
Date: 2016-10-12T10:39:35Z
CB-11951 CB-11990 CB-11967: Respect preference default values when install plugin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #501: CB-11951 CB-11967: Respect preference default...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/501
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #501: CB-11951 CB-11967: Respect preference default...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/501#discussion_r83341216
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -203,6 +204,23 @@ describe('plugin end-to-end', function() {
.fin(done);
});
+ it('should respect preference default values', function (done) {
+ addPlugin(path.join(pluginsDir, org_test_defaultvariables), org_test_defaultvariables, {cli_variables: { REQUIRED:'NO', REQUIRED_ANDROID:'NO'}}, done)
+ .then(function() {
+ var platformJsonPath = path.join(project, 'plugins', helpers.testPlatform + '.json');
+ var installed_plugins = JSON.parse(fs.readFileSync(platformJsonPath)).installed_plugins;
--- End diff --
Instead of `JSON.parse` & `fs.readFileSync`, why not use
```var installed_plugins = require('platformJsonPath').installed_plugins;```
That would remove the need to `require('fs')`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #501: CB-11951 CB-11967: Respect preference default values...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/501
## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/501?src=pr) is 80.40% (diff: 100%)
> Merging [#501](https://codecov.io/gh/apache/cordova-lib/pull/501?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will not change coverage
```diff
@@ master #501 diff @@
==========================================
Files 67 67
Lines 5189 5189
Methods 836 836
Messages 0 0
Branches 1005 1005
==========================================
Hits 4172 4172
Misses 1017 1017
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [c44db3d...51e171a](https://codecov.io/gh/apache/cordova-lib/compare/c44db3d7a00779d5c7eb5ae6150847156858a4f7...51e171a4a3802fe693de4603a08a3584e302e19c?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #501: CB-11951 CB-11967: Respect preference default values...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/501
Thanks for the pr @matrosov-nikita! merged! Feel free to close the issues on jira now :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #501: CB-11951 CB-11967: Respect preference default values...
Posted by matrosov-nikita <gi...@git.apache.org>.
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-lib/pull/501
@stevengill, thanks, updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org