You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/10 12:24:44 UTC

[GitHub] [flink] zentol opened a new pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

zentol opened a new pull request #14919:
URL: https://github.com/apache/flink/pull/14919


   Based on #14911 and #14918.
   
   Relaxes naming constraints for ITCases, such that any test not ending in `*Test.java` is considered an IT case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776676702


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 360f2b77255636af978380228b96c7f6bc2a4b77 (Wed Feb 10 12:34:41 UTC 2021)
   
   **Warnings:**
    * **2 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 360f2b77255636af978380228b96c7f6bc2a4b77 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 360f2b77255636af978380228b96c7f6bc2a4b77 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199) 
   * 12ef0b44ac73fe945b51118a9cda3ebc27d9c411 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205) 
   * 65a33645d217d8756e40a5c630680e30058f64cb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209",
       "triggerID" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 360f2b77255636af978380228b96c7f6bc2a4b77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199) 
   * 12ef0b44ac73fe945b51118a9cda3ebc27d9c411 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205) 
   * 65a33645d217d8756e40a5c630680e30058f64cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209",
       "triggerID" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 65a33645d217d8756e40a5c630680e30058f64cb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on a change in pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14919:
URL: https://github.com/apache/flink/pull/14919#discussion_r573701396



##########
File path: flink-tests/src/test/java/org/apache/flink/test/manual/CheckForbiddenMethodsUsage.java
##########
@@ -44,6 +45,7 @@
  * <p>Forbidden calls include: - Byte / String conversions that do not specify an explicit charset
  * because they produce different results in different locales
  */
+@Ignore("broken test")
 public class CheckForbiddenMethodsUsage {

Review comment:
       I think it would be helpful to include the JIRA IDs for the tickets to fix these broken tests. Otherwise, people might lack the context.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776676702


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 8a0ecec0b40fca539c5b89c234c48b2dcffd2699 (Fri Feb 19 07:33:36 UTC 2021)
   
   **Warnings:**
    * **2 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on a change in pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14919:
URL: https://github.com/apache/flink/pull/14919#discussion_r573701396



##########
File path: flink-tests/src/test/java/org/apache/flink/test/manual/CheckForbiddenMethodsUsage.java
##########
@@ -44,6 +45,7 @@
  * <p>Forbidden calls include: - Byte / String conversions that do not specify an explicit charset
  * because they produce different results in different locales
  */
+@Ignore("broken test")
 public class CheckForbiddenMethodsUsage {

Review comment:
       I think it would be helpful to include the JIRA IDs for the tickets for these broken tests. Otherwise, people might lack the context.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 360f2b77255636af978380228b96c7f6bc2a4b77 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199) 
   * 12ef0b44ac73fe945b51118a9cda3ebc27d9c411 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209",
       "triggerID" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13262",
       "triggerID" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "358404dbd7096506751ab384064d7b0a8261e48d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "358404dbd7096506751ab384064d7b0a8261e48d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13262) 
   * 358404dbd7096506751ab384064d7b0a8261e48d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209",
       "triggerID" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 12ef0b44ac73fe945b51118a9cda3ebc27d9c411 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205) 
   * 65a33645d217d8756e40a5c630680e30058f64cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol commented on a change in pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14919:
URL: https://github.com/apache/flink/pull/14919#discussion_r573775437



##########
File path: pom.xml
##########
@@ -1585,8 +1586,11 @@ under the License.
 						</goals>
 						<configuration>
 							<includes>
-								<include>**/*ITCase.*</include>
+								<include>**/*.java</include>

Review comment:
       hmm..IM wondering why this didn't disable the scala tests...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on a change in pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14919:
URL: https://github.com/apache/flink/pull/14919#discussion_r573701396



##########
File path: flink-tests/src/test/java/org/apache/flink/test/manual/CheckForbiddenMethodsUsage.java
##########
@@ -44,6 +45,7 @@
  * <p>Forbidden calls include: - Byte / String conversions that do not specify an explicit charset
  * because they produce different results in different locales
  */
+@Ignore("broken test")
 public class CheckForbiddenMethodsUsage {

Review comment:
       I think it would be helpful to include the JIRA IDs for the tickets to fix these broken tests. Otherwise, people might open duplicates, or generally lack context.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol merged pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14919:
URL: https://github.com/apache/flink/pull/14919


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209",
       "triggerID" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13262",
       "triggerID" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13262) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209",
       "triggerID" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 360f2b77255636af978380228b96c7f6bc2a4b77 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199) 
   * 12ef0b44ac73fe945b51118a9cda3ebc27d9c411 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205) 
   * 65a33645d217d8756e40a5c630680e30058f64cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209",
       "triggerID" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13262",
       "triggerID" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "358404dbd7096506751ab384064d7b0a8261e48d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13281",
       "triggerID" : "358404dbd7096506751ab384064d7b0a8261e48d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 358404dbd7096506751ab384064d7b0a8261e48d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13281) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209",
       "triggerID" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 65a33645d217d8756e40a5c630680e30058f64cb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209) 
   * 7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209",
       "triggerID" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13262",
       "triggerID" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "358404dbd7096506751ab384064d7b0a8261e48d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13281",
       "triggerID" : "358404dbd7096506751ab384064d7b0a8261e48d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13262) 
   * 358404dbd7096506751ab384064d7b0a8261e48d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13281) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 360f2b77255636af978380228b96c7f6bc2a4b77 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14919:
URL: https://github.com/apache/flink/pull/14919#issuecomment-776686704


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13199",
       "triggerID" : "360f2b77255636af978380228b96c7f6bc2a4b77",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13205",
       "triggerID" : "12ef0b44ac73fe945b51118a9cda3ebc27d9c411",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209",
       "triggerID" : "65a33645d217d8756e40a5c630680e30058f64cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13262",
       "triggerID" : "7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 65a33645d217d8756e40a5c630680e30058f64cb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13209) 
   * 7a95b8eb6d45c5e3c38f0c6cbed995b6d81a640b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13262) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org