[jira] [Commented] (NET-558) getModificationTime() returns complete received line including response code and EOL

["Sebb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NET-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623577#comment-14623577 ] 

Sebb commented on NET-558:
--------------------------

Further investigation shows that getModificationTime uses getReplyString() which adds NETASCII_EOL to each line (i.e. what the server would have sent).

That does not seem right; it should use getReplyStrings()[0] as is done by mdtmFile.
Fixed:

URL: http://svn.apache.org/r1690410
Log:
NET-558 - getModificationTime(<filename>) returns complete received line including response code and EOL

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPClient.java


> getModificationTime(<filename>) returns complete received line including response code and EOL
> ----------------------------------------------------------------------------------------------
>
>                 Key: NET-558
>                 URL: https://issues.apache.org/jira/browse/NET-558
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.3
>         Environment: The ftp server supports MDTM.
>            Reporter: Ralph Becker
>            Priority: Minor
>              Labels: commons-net, ftp
>             Fix For: 3.4
>
>
> When retrieving the last modification time of a file on the server via the 
> method getModificationTime(String filename) it returns something like 
> "213 20141111112706" where only the part after the space is the relevant data.
> I digged deeper and i found that the first part before the space is the positive 
> response code which is not removed before getModificationTime returns.
> I consider this a minor bug as i think there is a simple work around 
> (split by space, use second part only) but i do not believe that 
> the result of the method is what a user expects regarding the documentation 
> of that method. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)