You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by albertolalama <gi...@git.apache.org> on 2017/08/17 22:55:56 UTC
[GitHub] cordova-osx pull request #39: CB-12339: handle re-open app window
GitHub user albertolalama opened a pull request:
https://github.com/apache/cordova-osx/pull/39
CB-12339: handle re-open app window
### Platforms affected
osx
### What does this PR do?
When the app icon in the dock is clicked: re-opens the app window when if the app is closed. Brings the app window to the front if the app is running.
### What testing has been done on this change?
Manual verification.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
* I don't have much experience testing UX. Would like pointers if tests are required for this feature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/albertolalama/cordova-osx alalama-reopen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-osx/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit cc156f86ab4d11643703f41e1643882a9d5d8e63
Author: alberto lalama <al...@users.noreply.github.com>
Date: 2017-08-17T22:55:24Z
CB-12339: handle re-open app window
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx issue #39: CB-12339: handle re-open app window
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the issue:
https://github.com/apache/cordova-osx/pull/39
thanks for the patch. I will merge it in soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request #39: CB-12339: handle re-open app window
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-osx/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org