You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/20 15:53:56 UTC
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #4578: S32K1XXEVB boards: Fix RGB LED output and add comments
davids5 commented on a change in pull request #4578:
URL: https://github.com/apache/incubator-nuttx/pull/4578#discussion_r712299762
##########
File path: boards/arm/s32k1xx/s32k118evb/src/s32k1xx_userleds.c
##########
@@ -81,7 +81,7 @@ void board_userled(int led, bool ledon)
return;
}
- s32k1xx_gpiowrite(ledcfg, ledon);
+ s32k1xx_gpiowrite(ledcfg, ledon); /* An output of '1' illuminates the LED */
Review comment:
Comment on separate line.
##########
File path: boards/arm/s32k1xx/s32k146evb/src/s32k1xx_userleds.c
##########
@@ -81,7 +81,7 @@ void board_userled(int led, bool ledon)
return;
}
- s32k1xx_gpiowrite(ledcfg, ledon);
+ s32k1xx_gpiowrite(ledcfg, ledon); /* An output of '1' illuminates the LED */
Review comment:
"
##########
File path: boards/arm/s32k1xx/s32k144evb/src/s32k1xx_userleds.c
##########
@@ -81,7 +81,7 @@ void board_userled(int led, bool ledon)
return;
}
- s32k1xx_gpiowrite(ledcfg, ledon);
+ s32k1xx_gpiowrite(ledcfg, !ledon); /* Invert output, an output of '0' illuminates the LED */
Review comment:
"
##########
File path: boards/arm/s32k1xx/s32k148evb/src/s32k1xx_userleds.c
##########
@@ -81,7 +81,7 @@ void board_userled(int led, bool ledon)
return;
}
- s32k1xx_gpiowrite(ledcfg, ledon);
+ s32k1xx_gpiowrite(ledcfg, ledon); /* An output of '1' illuminates the LED */
Review comment:
"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org