[GitHub] spark pull request #22641: [SPARK-25611][SPARK-25612][SQL][TESTS] Improve te...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22641#discussion_r223216245
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/CompressionCodecSuite.scala ---
    @@ -271,10 +273,10 @@ class CompressionCodecSuite extends TestHiveSingleton with ParquetTest with Befo
                 isPartitioned,
                 convertMetastore,
                 usingCTAS,
    -            compressionCodecs = compressCodecs,
    -            tableCompressionCodecs = compressCodecs) {
    +            compressionCodecs = sessionCompressCodecs,
    +            tableCompressionCodecs = tableCompressCodecs) {
                 case (tableCodec, sessionCodec, realCodec, tableSize) =>
    -              val expectCodec = tableCodec.get
    +              val expectCodec = if (tableCodec.isDefined) tableCodec.get else sessionCodec
    --- End diff --
    
    I think this can be `tableCodec.getOrElse(sessionCodec)`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org