You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/11 13:39:19 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #3974: [HUDI-2741][WIP] Fixing instantiating metadata table config in HoodieFileIndex
nsivabalan opened a new pull request #3974:
URL: https://github.com/apache/hudi/pull/3974
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3974: [HUDI-2741] Fixing instantiating metadata table config in HoodieFileIndex
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3974:
URL: https://github.com/apache/hudi/pull/3974#discussion_r748553344
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieFileIndex.scala
##########
@@ -129,7 +129,7 @@ case class HoodieFileIndex(
// To support metadata listing via Spark SQL we allow users to pass the config via SQL Conf in spark session. Users
// would be able to run SET hoodie.metadata.enable=true in the spark sql session to enable metadata listing.
- properties.put(HoodieMetadataConfig.ENABLE,
+ properties.setProperty(HoodieMetadataConfig.ENABLE.key(),
Review comment:
we always look for string keys, thats why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3974: [HUDI-2741][WIP] Fixing instantiating metadata table config in HoodieFileIndex
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3974:
URL: https://github.com/apache/hudi/pull/3974#issuecomment-966355249
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7be8dcc48a79e52c6e40b25d6bf652c77d1291aa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3312",
"triggerID" : "7be8dcc48a79e52c6e40b25d6bf652c77d1291aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7be8dcc48a79e52c6e40b25d6bf652c77d1291aa Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3312)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3974: [HUDI-2741][WIP] Fixing instantiating metadata table config in HoodieFileIndex
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3974:
URL: https://github.com/apache/hudi/pull/3974#issuecomment-966314181
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7be8dcc48a79e52c6e40b25d6bf652c77d1291aa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3312",
"triggerID" : "7be8dcc48a79e52c6e40b25d6bf652c77d1291aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7be8dcc48a79e52c6e40b25d6bf652c77d1291aa Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3312)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3974: [HUDI-2741][WIP] Fixing instantiating metadata table config in HoodieFileIndex
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3974:
URL: https://github.com/apache/hudi/pull/3974#issuecomment-966312341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7be8dcc48a79e52c6e40b25d6bf652c77d1291aa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7be8dcc48a79e52c6e40b25d6bf652c77d1291aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7be8dcc48a79e52c6e40b25d6bf652c77d1291aa UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3974: [HUDI-2741] Fixing instantiating metadata table config in HoodieFileIndex
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3974:
URL: https://github.com/apache/hudi/pull/3974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #3974: [HUDI-2741] Fixing instantiating metadata table config in HoodieFileIndex
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #3974:
URL: https://github.com/apache/hudi/pull/3974#discussion_r747720123
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieFileIndex.scala
##########
@@ -129,7 +129,7 @@ case class HoodieFileIndex(
// To support metadata listing via Spark SQL we allow users to pass the config via SQL Conf in spark session. Users
// would be able to run SET hoodie.metadata.enable=true in the spark sql session to enable metadata listing.
- properties.put(HoodieMetadataConfig.ENABLE,
+ properties.setProperty(HoodieMetadataConfig.ENABLE.key(),
Review comment:
Previously we were putting the object, and now it is prop string, otherwise both `put()/setProperty()` should work right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3974: [HUDI-2741][WIP] Fixing instantiating metadata table config in HoodieFileIndex
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3974:
URL: https://github.com/apache/hudi/pull/3974#issuecomment-966314181
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7be8dcc48a79e52c6e40b25d6bf652c77d1291aa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3312",
"triggerID" : "7be8dcc48a79e52c6e40b25d6bf652c77d1291aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7be8dcc48a79e52c6e40b25d6bf652c77d1291aa Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3312)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3974: [HUDI-2741] Fixing instantiating metadata table config in HoodieFileIndex
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3974:
URL: https://github.com/apache/hudi/pull/3974#issuecomment-966371767
@hudi-bot azure run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3974: [HUDI-2741][WIP] Fixing instantiating metadata table config in HoodieFileIndex
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3974:
URL: https://github.com/apache/hudi/pull/3974#issuecomment-966312341
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7be8dcc48a79e52c6e40b25d6bf652c77d1291aa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7be8dcc48a79e52c6e40b25d6bf652c77d1291aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7be8dcc48a79e52c6e40b25d6bf652c77d1291aa UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org