You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/04/09 00:17:19 UTC
Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1178
https://issues.apache.org/jira/browse/MESOS-1178
Repository: mesos-git
Description
-------
Added cgroups::memory::oom_control and cgroups::memory::listen.
cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
Diffs
-----
src/linux/cgroups.hpp 5a5735721fb9f051eee661edb08d1cdaa163d0f3
src/linux/cgroups.cpp 8202c282f580d027a60ded2081962e96e4860f60
src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
src/tests/cgroups_tests.cpp 6ba9de622953e158feadaa9950618b0b13c9e832
Diff: https://reviews.apache.org/r/20137/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/#review39898
-----------------------------------------------------------
src/linux/cgroups.cpp
<https://reviews.apache.org/r/20137/#comment72644>
what's the benefit of overloading the oom_control name here? It seems that you could make 'enable' an option and return a Try<bool> to roll the two methods together.
- Dominic Hamon
On April 8, 2014, 3:17 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20137/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 3:17 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1178
> https://issues.apache.org/jira/browse/MESOS-1178
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added cgroups::memory::oom_control and cgroups::memory::listen.
>
> cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 5a5735721fb9f051eee661edb08d1cdaa163d0f3
> src/linux/cgroups.cpp 8202c282f580d027a60ded2081962e96e4860f60
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/tests/cgroups_tests.cpp 6ba9de622953e158feadaa9950618b0b13c9e832
>
> Diff: https://reviews.apache.org/r/20137/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/#review39890
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20137]
All tests passed.
- Mesos ReviewBot
On April 8, 2014, 10:17 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20137/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 10:17 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1178
> https://issues.apache.org/jira/browse/MESOS-1178
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added cgroups::memory::oom_control and cgroups::memory::listen.
>
> cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 5a5735721fb9f051eee661edb08d1cdaa163d0f3
> src/linux/cgroups.cpp 8202c282f580d027a60ded2081962e96e4860f60
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/tests/cgroups_tests.cpp 6ba9de622953e158feadaa9950618b0b13c9e832
>
> Diff: https://reviews.apache.org/r/20137/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Ian Downes <ia...@gmail.com>.
> On April 9, 2014, 1:22 p.m., Ben Mahler wrote:
> > src/slave/containerizer/isolators/cgroups/mem.cpp, lines 91-92
> > <https://reviews.apache.org/r/20137/diff/1/?file=553431#file553431line91>
> >
> > It's a bit unfortunate that the code is not that clear without the comments. We're passing 'true' into something called 'oom_control' which doesn't really tell us that we're enabling the oom killer. Seems like this is a place where the direct mapping from control names to function names is a bit unfortunate.
> >
> > I guess this is ok for now.
I changed the method to oom_control_enabled() with an Option<bool> to change state.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/#review39927
-----------------------------------------------------------
On June 8, 2014, 8:54 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20137/
> -----------------------------------------------------------
>
> (Updated June 8, 2014, 8:54 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1178
> https://issues.apache.org/jira/browse/MESOS-1178
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added cgroups::memory::oom_control and cgroups::memory::listen.
>
> cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e
> src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1
> src/slave/containerizer/isolators/cgroups/mem.hpp 362ebcfa2e16701b225deea0fbeb92e4a56d51aa
> src/slave/containerizer/isolators/cgroups/mem.cpp 60013d4e840f6b1f131b796b95916d1978b37c70
> src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
>
> Diff: https://reviews.apache.org/r/20137/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/#review39927
-----------------------------------------------------------
src/linux/cgroups.hpp
<https://reviews.apache.org/r/20137/#comment72695>
What does this return? That is, what does the uint64_t represent and can we either add a comment (if it's useful) or convert it to Nothing() if it's an artifact of the listening technique?
The name here might be a bit opaque. 'cgroups::memory::listen' doesn't really tell us what we're listening for.
What about 'cgroups::memory::oomListen'? You'll notice the other methods here were named with snake case, this was to directly match the control file names.
src/linux/cgroups.cpp
<https://reviews.apache.org/r/20137/#comment72694>
We should add a check for the format we expect:
if (pairs.count("oom_kill_disable") != 1 ||
pairs["oom_kill_disable"].empty()) {
return Errror(...);
}
src/slave/containerizer/isolators/cgroups/mem.cpp
<https://reviews.apache.org/r/20137/#comment72696>
It's a bit unfortunate that the code is not that clear without the comments. We're passing 'true' into something called 'oom_control' which doesn't really tell us that we're enabling the oom killer. Seems like this is a place where the direct mapping from control names to function names is a bit unfortunate.
I guess this is ok for now.
- Ben Mahler
On April 8, 2014, 10:17 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20137/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 10:17 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1178
> https://issues.apache.org/jira/browse/MESOS-1178
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added cgroups::memory::oom_control and cgroups::memory::listen.
>
> cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 5a5735721fb9f051eee661edb08d1cdaa163d0f3
> src/linux/cgroups.cpp 8202c282f580d027a60ded2081962e96e4860f60
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/tests/cgroups_tests.cpp 6ba9de622953e158feadaa9950618b0b13c9e832
>
> Diff: https://reviews.apache.org/r/20137/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/#review46069
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20137]
All tests passed.
- Mesos ReviewBot
On June 17, 2014, 9:27 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20137/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 9:27 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1178
> https://issues.apache.org/jira/browse/MESOS-1178
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added cgroups::memory::oom_control and cgroups::memory::listen.
>
> cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 75c5602baa5a5bbf3bba1c6f9df61b0a2027e029
> src/linux/cgroups.cpp a4274a85939a2e84e03f67c6003182cbb0ab9b67
> src/slave/containerizer/isolators/cgroups/mem.hpp 33b0ca8e412c0da294f7942019d5ffca15cc0130
> src/slave/containerizer/isolators/cgroups/mem.cpp 3b731f90e452d3dd6496988273e3b1ec69c9b4f7
> src/tests/cgroups_tests.cpp bfb585818daacfa6dc605ba8430b097cfea7cafc
>
> Diff: https://reviews.apache.org/r/20137/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/#review46025
-----------------------------------------------------------
Ship it!
There's a bug that can crash the program, but otherwise looks good. Please go ahead and commit after addressing comments.
src/linux/cgroups.cpp
<https://reviews.apache.org/r/20137/#comment81189>
You can't call .error() if 'exists' is false!
src/linux/cgroups.cpp
<https://reviews.apache.org/r/20137/#comment81190>
How about:
return pairs["oom_kill_disable"].front() == "0";
src/linux/cgroups.cpp
<https://reviews.apache.org/r/20137/#comment81191>
Should this have an error prefix string like you did inside 'enabled' above?
src/linux/cgroups.cpp
<https://reviews.apache.org/r/20137/#comment81192>
Ditto.
- Ben Mahler
On June 17, 2014, 9:27 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20137/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 9:27 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1178
> https://issues.apache.org/jira/browse/MESOS-1178
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added cgroups::memory::oom_control and cgroups::memory::listen.
>
> cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 75c5602baa5a5bbf3bba1c6f9df61b0a2027e029
> src/linux/cgroups.cpp a4274a85939a2e84e03f67c6003182cbb0ab9b67
> src/slave/containerizer/isolators/cgroups/mem.hpp 33b0ca8e412c0da294f7942019d5ffca15cc0130
> src/slave/containerizer/isolators/cgroups/mem.cpp 3b731f90e452d3dd6496988273e3b1ec69c9b4f7
> src/tests/cgroups_tests.cpp bfb585818daacfa6dc605ba8430b097cfea7cafc
>
> Diff: https://reviews.apache.org/r/20137/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/
-----------------------------------------------------------
(Updated June 17, 2014, 2:27 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Addressed Ben and Vinod's comments.
Bugs: MESOS-1178
https://issues.apache.org/jira/browse/MESOS-1178
Repository: mesos-git
Description
-------
Added cgroups::memory::oom_control and cgroups::memory::listen.
cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
Diffs (updated)
-----
src/linux/cgroups.hpp 75c5602baa5a5bbf3bba1c6f9df61b0a2027e029
src/linux/cgroups.cpp a4274a85939a2e84e03f67c6003182cbb0ab9b67
src/slave/containerizer/isolators/cgroups/mem.hpp 33b0ca8e412c0da294f7942019d5ffca15cc0130
src/slave/containerizer/isolators/cgroups/mem.cpp 3b731f90e452d3dd6496988273e3b1ec69c9b4f7
src/tests/cgroups_tests.cpp bfb585818daacfa6dc605ba8430b097cfea7cafc
Diff: https://reviews.apache.org/r/20137/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/#review45579
-----------------------------------------------------------
Bad patch!
Reviews applied: [20137]
Failed command: ./support/mesos-style.py
Error:
Checking 470 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
src/tests/cgroups_tests.cpp:524: Lines should be <= 80 characters long [whitespace/line_length] [2]
Total errors found: 1
- Mesos ReviewBot
On June 12, 2014, 9:57 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20137/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 9:57 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1178
> https://issues.apache.org/jira/browse/MESOS-1178
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added cgroups::memory::oom_control and cgroups::memory::listen.
>
> cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e
> src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1
> src/slave/containerizer/isolators/cgroups/mem.hpp 362ebcfa2e16701b225deea0fbeb92e4a56d51aa
> src/slave/containerizer/isolators/cgroups/mem.cpp 60013d4e840f6b1f131b796b95916d1978b37c70
> src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
>
> Diff: https://reviews.apache.org/r/20137/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/
-----------------------------------------------------------
(Updated June 12, 2014, 9:57 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
I will shepherd this one.
--bmahler
Bugs: MESOS-1178
https://issues.apache.org/jira/browse/MESOS-1178
Repository: mesos-git
Description
-------
Added cgroups::memory::oom_control and cgroups::memory::listen.
cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
Diffs
-----
src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e
src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1
src/slave/containerizer/isolators/cgroups/mem.hpp 362ebcfa2e16701b225deea0fbeb92e4a56d51aa
src/slave/containerizer/isolators/cgroups/mem.cpp 60013d4e840f6b1f131b796b95916d1978b37c70
src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
Diff: https://reviews.apache.org/r/20137/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/#review45540
-----------------------------------------------------------
src/linux/cgroups.hpp
<https://reviews.apache.org/r/20137/#comment80387>
Can we split this into two methods? An Option<bool> seems a bit weird.
oom_control_enabled()
and
oom_control_enable()
- Vinod Kone
On June 9, 2014, 3:54 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20137/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 3:54 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1178
> https://issues.apache.org/jira/browse/MESOS-1178
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added cgroups::memory::oom_control and cgroups::memory::listen.
>
> cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e
> src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1
> src/slave/containerizer/isolators/cgroups/mem.hpp 362ebcfa2e16701b225deea0fbeb92e4a56d51aa
> src/slave/containerizer/isolators/cgroups/mem.cpp 60013d4e840f6b1f131b796b95916d1978b37c70
> src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
>
> Diff: https://reviews.apache.org/r/20137/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/#review45539
-----------------------------------------------------------
It looks like the API could be made a little more clear here, see my comment below.
src/linux/cgroups.hpp
<https://reviews.apache.org/r/20137/#comment80385>
I would suggest the following scheme:
(1) Try<bool> enabled = memory::oom::killer::enabled(hierarchy, cgroup)
(2) Try<Nothing> enable = memory::oom::killer::enable(hierarchy, cgroup)
(3) Try<Nothing> disable = memory::oom::killer::disable(hierarchy, cgroup)
(4) Future<Nothing> oom = memory::oom::listen(hierarchy, cgroup)
Isn't it more intuitive to say "killer" than "control"? It also seems confusing to read the enable/disable cases as inquiries. Without the comment above the following code I'm not sure it would read intuitively:
// Disable the oom killer.
Try<bool> enabled = memory::oom_control_enabled(hierarchy, cgroup, false);
I think our snake_case matching with the control file names breaks down now and we should move away from it. Let's do that later though:
Try<Nothing> limit = memory::setLimit(hierarchy, cgroup, Megabytes(1));
Try<Bytes> limit = memory::limit(hierarchy, cgroup);
Try<Nothing> softLimit = memory::setSoftLimit(hierarchy, cgroup, Megabytes(1));
Try<Bytes> softLimit = memory::softLimit(hierarchy, cgroup);
Try<Bytes> usage = memory::usage(hierarchy, cgroup);
Try<Bytes> usage = memory::maxUsage(hierarchy, cgroup);
src/linux/cgroups.cpp
<https://reviews.apache.org/r/20137/#comment80386>
Does this need to be a Future<Nothing> or can it just be a Nothing?
- Ben Mahler
On June 9, 2014, 3:54 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20137/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 3:54 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1178
> https://issues.apache.org/jira/browse/MESOS-1178
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added cgroups::memory::oom_control and cgroups::memory::listen.
>
> cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e
> src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1
> src/slave/containerizer/isolators/cgroups/mem.hpp 362ebcfa2e16701b225deea0fbeb92e4a56d51aa
> src/slave/containerizer/isolators/cgroups/mem.cpp 60013d4e840f6b1f131b796b95916d1978b37c70
> src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
>
> Diff: https://reviews.apache.org/r/20137/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20137: Added cgroups::memory::oom_control and
cgroups::memory::listen.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20137/
-----------------------------------------------------------
(Updated June 8, 2014, 8:54 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Addressed comments.
Bugs: MESOS-1178
https://issues.apache.org/jira/browse/MESOS-1178
Repository: mesos-git
Description
-------
Added cgroups::memory::oom_control and cgroups::memory::listen.
cgroups::memory::oom_control will not write to the control file unless it needs to change the state.
Diffs (updated)
-----
src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e
src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1
src/slave/containerizer/isolators/cgroups/mem.hpp 362ebcfa2e16701b225deea0fbeb92e4a56d51aa
src/slave/containerizer/isolators/cgroups/mem.cpp 60013d4e840f6b1f131b796b95916d1978b37c70
src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
Diff: https://reviews.apache.org/r/20137/diff/
Testing
-------
make check
Thanks,
Ian Downes