You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by RongGu <gi...@git.apache.org> on 2014/10/31 03:57:31 UTC

[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

GitHub user RongGu opened a pull request:

    https://github.com/apache/spark/pull/3030

    [SPARK-2703][Core]Make Tachyon related unit tests execute without deploying a Tachyon system locally.

    Make Tachyon related unit tests execute without deploying a Tachyon system locally.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PasaLab/spark SPARK-2703

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/3030.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3030
    
----
commit ad08827e565a7af78614405ca85f877ef8ed2fe7
Author: RongGu <gu...@gmail.com>
Date:   2014-10-30T15:57:25Z

    Make Tachyon related unit tests execute without deploying a Tachyon system locally

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/3030#issuecomment-62436181
  
    It looks like this PR may have broken the Maven builds, but I'm not sure why:
    
    https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-Maven-pre-YARN/955/
    https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-Maven-with-YARN/882/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/3030#issuecomment-62350196
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23137/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/3030


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/3030#issuecomment-62351083
  
    This takes about 1.6 seconds. That's pretty long but I think it's fine. I can merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/3030#issuecomment-61209472
  
      [Test build #22590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22590/consoleFull) for   PR 3030 at commit [`ad08827`](https://github.com/apache/spark/commit/ad08827e565a7af78614405ca85f877ef8ed2fe7).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/3030#issuecomment-62350194
  
      [Test build #23137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23137/consoleFull) for   PR 3030 at commit [`ad08827`](https://github.com/apache/spark/commit/ad08827e565a7af78614405ca85f877ef8ed2fe7).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by haoyuan <gi...@git.apache.org>.
Github user haoyuan commented on the pull request:

    https://github.com/apache/spark/pull/3030#issuecomment-61373010
  
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/3030#issuecomment-61215556
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22590/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/3030#issuecomment-61215545
  
      [Test build #22590 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22590/consoleFull) for   PR 3030 at commit [`ad08827`](https://github.com/apache/spark/commit/ad08827e565a7af78614405ca85f877ef8ed2fe7).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by RongGu <gi...@git.apache.org>.
Github user RongGu commented on the pull request:

    https://github.com/apache/spark/pull/3030#issuecomment-61208880
  
    @haoyuan 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/3030#issuecomment-62344873
  
    Jenkins, retest this please. This looks good except I'm wondering - how long do these tests take? Is it more than 1 second?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2703][Core]Make Tachyon related unit te...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/3030#issuecomment-62345244
  
      [Test build #23137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23137/consoleFull) for   PR 3030 at commit [`ad08827`](https://github.com/apache/spark/commit/ad08827e565a7af78614405ca85f877ef8ed2fe7).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org