You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/07/05 17:23:45 UTC

[GitHub] [incubator-shardingsphere] penghuiy commented on issue #2663: how to set datasource readonly

penghuiy commented on issue #2663: how to set datasource readonly
URL: https://github.com/apache/incubator-shardingsphere/issues/2663#issuecomment-508820982
 
 
   @terrymanu 
   I have found a discussion about the hikari pool(https://github.com/brettwooldridge/HikariCP/issues/1116). 
   Based on the results of the discussion, I think I should explicitly specify isReadOnly. If not specified, the jdbc driver will throw an exception unpredictably, resulting in a connection not being established properly.
   
   If improvements are made, I think
   YamlDataSourceParameter should add the isReadOnly parameter, then
   config.setReadOnly(dataSourceParameter.isReadOnly());
   
   Please let me know if there are other objections.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services